Add InfluxDB Connector by k3rnL · Pull Request #24220 · trinodb/trino

k3rnL · 2024-11-21T23:48:41Z

Description

This PR introduces a new connector for InfluxDB, enabling Trino to query time-series data stored in InfluxDB. InfluxDB is a widely used time-series database but diverges from many traditional database standards, requiring a tailored approach to integration.

Additional context and related issues

I must note that most of the work was made in the past, but the PR was never finalized #15549
I have mostly only rebased the code, fixed tests and adapt the code to the new requirements.
My addition is the support for schema creation and schema/table destruction.

Release notes

( ) Release notes are required, with the following suggested text:

## Section
* Add InfluxDB connector. ({issue}`issuenumber`)

k3rnL · 2024-11-23T12:42:07Z

I'm not sure if the CI fails because of the PR's code or if the tests are flaky ?

ebyhr · 2024-11-24T05:30:54Z

ci / pt (default, suite-all-connectors-smoke, ) looks related to this change. Other failures are unrelated.

github-actions · 2024-12-16T17:03:01Z

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

github-actions · 2025-01-06T17:03:14Z

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

diegocareaga · 2025-02-17T18:47:14Z

Hey @k3rnL Do you know what happened at the end? I will be happy to collaborate with you. I see your connector really interesting. 👍

k3rnL · 2025-02-17T20:20:01Z

A lack of time mostly ! The connector is working well, the problem is to be compliant with the autonomous tests..
I was close to pass all the tests though, I think it does not need a lot of work to pass the tests.

diegocareaga · 2025-02-18T00:32:47Z

@k3rnL Could you please update the pom.xml in (plugin/trino-influxdb) with this version of trino-root snapshot? and try again? 471

471-SNAPSHOT instead of 466-SNAPSHOT and then we will see what happen

diegocareaga · 2025-02-18T05:00:38Z

Hi @k3rnL
I noticed two small things we can fix:

Your pom.xml needs a version update - just change 466-SNAPSHOT to match current version (471-SNAPSHOT). @ebyhr helped us with that but I don't know what happened - maybe a problem with cache here? becase the outdated file is only here -> /home/runner/work/trino/trino/plugin/trino-influxdb/pom.xml
There are some test failures in trino-loki module (not in your influxdb connector). Maybe we could update to the latest version and rebuild?

Really excited to try your InfluxDB connector! I'm eager to collaborate once I have access. Let me know if you need help with these fixes 😊

k3rnL · 2025-02-18T12:05:23Z

Seems @ebyhr just outperformed us 😁 Thank ! But I see that the merging is blocked because of a merge commit, but it seems this commit comes from the main branch itself. I may be mistaken, but I carefully rebased the code..

diegocareaga · 2025-02-18T13:07:06Z

@k3rnL congrats you already passed all the tests. Do you know what is the next step? if not I will ask in the slack channel

k3rnL · 2025-02-18T15:16:02Z

Perfect ! That was faster than I thought :)
Yes you may ask, thanks for your help :)

k3rnL

I've made the corrections following your comments

github-actions · 2025-09-03T17:03:13Z

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

k3rnL · 2025-09-04T19:24:11Z

@ebyhr Is there something more I can do ?

github-actions · 2025-09-26T17:03:15Z

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

github-actions · 2025-10-17T17:03:25Z

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

dlandz · 2025-11-05T15:45:34Z

@ebyhr can we get this reviewed again?
@k3rnL thanks for your work on this, does it need to be re-merged post release 478?

github-actions · 2025-11-26T17:03:32Z

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

findepi · 2025-11-27T11:31:11Z

+            }
+        }
+        catch (Exception e) {
+            if (this.dockerContainer != null) {


nit: move this.dockerContainer = before try and remove the condition

findepi · 2025-11-27T11:31:22Z

+        }
+        catch (Exception e) {
+            if (this.dockerContainer != null) {
+                this.dockerContainer.close();


use closeAllSuppress

findepi · 2025-11-27T11:31:47Z

+
+    public String getEndpoint()
+    {
+        return this.dockerContainer.getUrl();


this. is redundant, please remove (& elsewhere)

chenjian2664 · 2025-11-28T01:53:16Z

+    @AssertFalse(message = "'influx.username' and 'influx.password' must be both empty or both non-empty.")
+    public boolean isValidPasswordConfig()
+    {
+        return (username == null) ^ (password == null);
+    }


The check seems wrong

chenjian2664 · 2025-11-28T01:54:59Z

+        boolean hasCreds = (username != null) || (password != null);
+        if (!hasCreds || endpoint == null) {
+            return true;
+        }
+        String scheme = URI.create(endpoint).getScheme();
+        return insecureAllowed || "https".equalsIgnoreCase(scheme);


Could you reorder the check like:

if (endpoint == null) { .... } // otherwise ...

chenjian2664 · 2025-11-28T01:57:55Z

+    {
+        InfluxTableHandle tableHandle = (InfluxTableHandle) handle;
+        if (client.findTableHandle(tableHandle.schemaName(), tableHandle.tableName()).isEmpty()) {
+            throw new TableNotFoundException(tableHandle.toSchemaTableName());


Not sure it is needed, engine should potentially check the case

chenjian2664 · 2025-11-28T01:58:43Z

+public record InfluxRecord(List<String> columns, List<List<Object>> values)
+{
+}


Suggested change

public record InfluxRecord(List<String> columns, List<List<Object>> values)

{

}

public record InfluxRecord(List<String> columns, List<List<Object>> values)

{}

chenjian2664 · 2025-11-28T02:01:17Z

+        if (value instanceof Number number) {
+            return number.intValue() != 0;
+        }
+        return false;


is the influxDB says other types value except boolea/number is treated as "false" ?

chenjian2664 · 2025-11-28T02:01:35Z

+        if (value instanceof Number number) {
+            return number.longValue();
+        }
+        return 0;


same here, why not throw exception

chenjian2664 · 2025-11-28T02:03:27Z

+            }
+            else {
+                ImmutableList.Builder<String> columns = ImmutableList.builder();
+                List<List<Object>> values = new ArrayList<>();


use ImmutableList

github-actions · 2025-12-19T17:04:38Z

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

mosabua · 2025-12-19T19:46:40Z

Since @colebow is now at InfluxData I am assigning this PR to him. @k3rnL please work with him on addressing the PR feedback and any further discussions here or on Trino slack.

I am assuming you will want to drive this PR towards merge and have therefore given it the stale-ignore label to avoid further noise.

k3rnL · 2025-12-20T12:34:11Z

Alright, I have not planned to work on it until beginning of the next year, I have no time for it unfortunately. But it will be a pleasure to work with you @colebow in the beginning of 2026.

I'm definitely motivated to have this PR closed, time is the only issue :)

github-actions Bot added the docs label Nov 21, 2024

k3rnL force-pushed the k3rnl/influxdb-connector branch 9 times, most recently from c26a3f8 to caed040 Compare November 22, 2024 22:30

k3rnL force-pushed the k3rnl/influxdb-connector branch from caed040 to 480d66d Compare November 24, 2024 21:49

github-actions Bot added the stale label Dec 16, 2024

github-actions Bot closed this Jan 6, 2025

k3rnL reopened this Feb 17, 2025

k3rnL force-pushed the k3rnl/influxdb-connector branch from 480d66d to 42a0cb4 Compare February 17, 2025 20:20

cla-bot Bot added the cla-signed label Feb 17, 2025

ebyhr mentioned this pull request Feb 18, 2025

Influxdb connector #25053

Closed

ebyhr force-pushed the k3rnl/influxdb-connector branch from 42a0cb4 to b19ea18 Compare February 18, 2025 01:12

ebyhr force-pushed the k3rnl/influxdb-connector branch from b19ea18 to e30e1f4 Compare February 18, 2025 10:12

k3rnL force-pushed the k3rnl/influxdb-connector branch 2 times, most recently from ef05025 to 8f110cf Compare August 13, 2025 00:03

Add InfluxDB connector

8e6dfdc

k3rnL force-pushed the k3rnl/influxdb-connector branch from 8f110cf to 8e6dfdc Compare August 13, 2025 00:12

k3rnL commented Aug 13, 2025

View reviewed changes

github-actions Bot added the stale label Sep 3, 2025

github-actions Bot removed the stale label Sep 5, 2025

github-actions Bot added the stale label Sep 26, 2025

github-actions Bot closed this Oct 17, 2025

k3rnL reopened this Oct 17, 2025

github-actions Bot removed the stale label Oct 20, 2025

Merge branch 'master' into k3rnl/influxdb-connector

0d5f250

github-actions Bot added the stale label Nov 26, 2025

Merge branch 'master' into k3rnl/influxdb-connector

17f4a37

findepi reviewed Nov 27, 2025

View reviewed changes

github-actions Bot removed the stale label Nov 27, 2025

chenjian2664 reviewed Nov 28, 2025

View reviewed changes

github-actions Bot added the stale label Dec 19, 2025

mosabua assigned colebow Dec 19, 2025

mosabua added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Dec 19, 2025

Conversation

k3rnL commented Nov 21, 2024

Description

Additional context and related issues

Release notes

Uh oh!

k3rnL commented Nov 23, 2024

Uh oh!

ebyhr commented Nov 24, 2024

Uh oh!

github-actions Bot commented Dec 16, 2024

Uh oh!

github-actions Bot commented Jan 6, 2025

Uh oh!

diegocareaga commented Feb 17, 2025

Uh oh!

k3rnL commented Feb 17, 2025

Uh oh!

diegocareaga commented Feb 18, 2025

Uh oh!

diegocareaga commented Feb 18, 2025

Uh oh!

k3rnL commented Feb 18, 2025

Uh oh!

diegocareaga commented Feb 18, 2025

Uh oh!

k3rnL commented Feb 18, 2025

Uh oh!

k3rnL left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 3, 2025

Uh oh!

k3rnL commented Sep 4, 2025

Uh oh!

github-actions Bot commented Sep 26, 2025

Uh oh!

github-actions Bot commented Oct 17, 2025

Uh oh!

dlandz commented Nov 5, 2025

Uh oh!

github-actions Bot commented Nov 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Dec 19, 2025

Uh oh!

mosabua commented Dec 19, 2025

Uh oh!

k3rnL commented Dec 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

10 participants