Skip to content

Introduce automountServiceAccountToken management#420

Open
aspring wants to merge 6 commits into
trinodb:mainfrom
aspring:aspring/feat/automountServiceAccountToken
Open

Introduce automountServiceAccountToken management#420
aspring wants to merge 6 commits into
trinodb:mainfrom
aspring:aspring/feat/automountServiceAccountToken

Conversation

@aspring
Copy link
Copy Markdown

@aspring aspring commented Apr 23, 2026

This change introduces 'serviceaccount.automount`, which defaults to false, to allow configuring the automountServiceAccountToken setting of the service account.

…Token

This change introduces 'serviceaccount.automount`, which defaults to false, to allow configuring the automountServiceAccountToken setting of the service account.
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 23, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 23, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@aspring
Copy link
Copy Markdown
Author

aspring commented Apr 27, 2026

CLA has been signed and acknowledged

@nineinchnick
Copy link
Copy Markdown
Member

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label Apr 28, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 28, 2026

The cla-bot has been summoned, and re-checked this pull request!

@nineinchnick nineinchnick changed the title feat: Introduce automountServiceAccountToken management Introduce automountServiceAccountToken management Apr 28, 2026
Comment thread charts/trino/values.yaml Outdated
@nineinchnick nineinchnick added the enhancement New feature or request label Apr 28, 2026
@nineinchnick
Copy link
Copy Markdown
Member

@aspring since you also made the change in the gateway chart, please squash the two commits for the trino chart together and remove the unnecessary commit message prefixes.

aspring added 3 commits April 28, 2026 17:34
This change introduces 'serviceaccount.automount`, which defaults to false, to allow configuring the automountServiceAccountToken setting of the service account.
…ountToken' into aspring/feat/automountServiceAccountToken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

2 participants