Add installation instructions for translation files

[WaterWhisperer]

Fixes: #1503

[squell]

Looks good to me, thanks for this!

Note: this PR also addresses several unrelated whitespace or formatting fixes. Those are fine too, but I would have had a slight preference for putting this in a seperate commit. But not a reason to do that now.

[bjorn3]

We don't ship Makefile in release bundles, nor pre-compiled translations. Should we? At least for the Makefile before this PR it exclusively contains rules that are not meant to be invoked by someone building sudo-rs.

[WaterWhisperer]

We don't ship Makefile in release bundles, nor pre-compiled translations. Should we? At least for the Makefile before this PR it exclusively contains rules that are not meant to be invoked by someone building sudo-rs.

Thanks for the confirms. Before I change direction further: would you prefer the README to document the direct msgfmt + install-path steps instead of relying on make install-mo, given that release bundles don’t ship the Makefile?

[squell]

We don't ship Makefile in release bundles, nor pre-compiled translations. Should we? At least for the Makefile before this PR it exclusively contains rules that are not meant to be invoked by someone building sudo-rs.

• For the makefile: maybe not a bad idea to add that to the release bundle; although it also of course depends on the PAM-detection script. Pre-compiled translations: I don't think we need to do that. Note that I'd consider this addition a convenience that's useful during development primarily (I don't work with gettext daily so have had to look up the syntax a number of times already; this addition would have saved me time). Distributors would have their own way of installing .mo files already, presumably.

  Edit I got confused here: I was thinking that we have a source tarball that's different from the state of the repository, but that's not the case. So if someone is building from source, they already have the Makefile. Ignore the above.

• For a precompiled translation distribution, I think I would think along the lines of adding a "language pack" as a separate tarball, maybe. TBD.

[squell]

We don't ship Makefile in release bundles, nor pre-compiled translations. Should we? At least for the Makefile before this PR it exclusively contains rules that are not meant to be invoked by someone building sudo-rs.

Thanks for the confirms. Before I change direction further: would you prefer the README to document the direct msgfmt + install-path steps instead of relying on make install-mo, given that release bundles don’t ship the Makefile?

As an outsider, I'd prefer instructions involving make which I have used tons of times in my life, rather than type this long sequence of commands I have never used before. I think we just need to think about whether we want to upgrade the makefile to also add other things like installing the sudo-rs binary itself, etc.

[squell]

Thanks for the changes!