Skip to content

Detect panics early in test framework Output construction #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjorn3 merged 4 commits into from
Apr 17, 2026
Merged

Detect panics early in test framework Output construction #1541

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c44e524
test: detect panics in test framework Output construction
Sim-hu Apr 7, 2026
a3b65e6
fix: correct rustfmt formatting for panic detection
Sim-hu Apr 7, 2026
abe8b0b
refactor: merge panic detection conditions per review feedback
Sim-hu Apr 7, 2026
e60c882
style: apply cargo fmt for test-framework
Sim-hu Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test-framework/sudo-test/src/docker/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,15 @@ impl TryFrom<process::Output> for Output {
stdout.pop();
}

// detect Rust panics early: exit code 101 is the default panic exit code
if output.status.code() == Some(101) {
panic!("program panicked (exit code 101)\nstdout:\n{stdout}\n\nstderr:\n{stderr}");
}

if stderr.contains("panicked") {
panic!("program panicked\nstdout:\n{stdout}\n\nstderr:\n{stderr}");
Comment thread
bjorn3 marked this conversation as resolved.
Outdated
}

Ok(Output {
status: output.status,
stderr,
Expand Down
Loading