Skip to content

fix+refactor: [alb] hardening sweep + shared fanout primitive#1001

Merged
crandles merged 6 commits into
trickstercache:mainfrom
crandles:alb-review
May 14, 2026
Merged

fix+refactor: [alb] hardening sweep + shared fanout primitive#1001
crandles merged 6 commits into
trickstercache:mainfrom
crandles:alb-review

Conversation

@crandles
Copy link
Copy Markdown
Contributor

@crandles crandles commented May 13, 2026 •
edited
Loading

Description

ALB hardening, continued. Before this PR, the following could silently go wrong:

  • TSM client disconnects didn't cancel upstreams
  • NLM rejected the IMF-fixdate "GMT" Last-Modified format real servers emit
  • UR options raced against SIGHUP reload
  • TSM error aggregation surfaced min status when all members failed (one 400 could hide 502s)
  • FR and NLM raced on the POST request body during fanout clone
  • One oversized upstream could OOM the proxy; capped via max_capture_bytes (default 256 MiB)
  • UnmarshalTimeseriesReader panicked on a nil reader

Adds trickster_alb_fanout_failures_total{mechanism,reason}.

Also extracts pkg/backends/alb/mech/fanout.

code:   +593 -278
test:   +1693 -4

Not seeing anything obvious left to test at this point, going to call it done for now.

Type of Change

    • Bug fix
    • New feature
    • Test coverage

AI Disclosure

    • This contribution DOES include AI-generated changes, and I have reviewed the relevant contributing guidelines.

crandles added 3 commits May 13, 2026 14:26
@crandles
fix: [alb] post-audit hardening: tsm ctx, nlm parser, ur race, bounde…
608dbf7 
…d captures

Signed-off-by: Chris Randles <randles.chris@gmail.com>
@crandles
test: [alb] add helper unit tests, panic guards, goleak, badEncoding …
fdb2e05 
…fault

Signed-off-by: Chris Randles <randles.chris@gmail.com>
@crandles
fix+feat: [alb] strip cache headers from merge, fanout failure metric…
4c911fd 
…, prime post body

Signed-off-by: Chris Randles <randles.chris@gmail.com>
@crandles crandles changed the title fix+test: [alb] post-audit hardening: ctx, parser, races, body, captures, metric fix+refactor: [alb] hardening sweep + shared fanout primitive May 13, 2026
@crandles
refactor: [alb/mech] extract shared fanout primitive; migrate nlm, ts…
c5a7af9 
…m, fr clone setup

Signed-off-by: Chris Randles <randles.chris@gmail.com>
@crandles
feat: [alb,backends] make max_capture_bytes configurable
98bd33e 
Signed-off-by: Chris Randles <randles.chris@gmail.com>
@crandles crandles marked this pull request as ready for review May 13, 2026 20:28
@crandles crandles requested a review from a team as a code owner May 13, 2026 20:28
jranson
jranson approved these changes May 14, 2026
View reviewed changes
Comment thread pkg/backends/alb/mech/fanout/fanout.go Outdated
@crandles
refactor: [alb/mech] split fanout Mechanism + Variant; use types.Name
1cff399 
Signed-off-by: Chris Randles <randles.chris@gmail.com>
@crandles crandles merged commit dc1fd3b into trickstercache:main May 14, 2026
8 checks passed
@crandles crandles deleted the alb-review branch May 14, 2026 12:03
@thinker0 thinker0 mentioned this pull request May 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jranson jranson jranson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crandles @jranson