Resolve Rails 8.1 deprecation warnings in the dummy application - #661
Merged
Conversation
tricknotes
force-pushed
the
fix-rails-deprecations
branch
from
September 4, 2026 08:48
059aeb2 to
838b557
Compare
Rails 8.1 deprecates assigning `config.active_support.to_time_preserves_timezone`, since preserving the timezone is now the only behavior: keep the assignment only for older Rails versions. It also deprecates hash arguments to route helpers, which HighVoltage's `/pages/*id` engine route still uses. The dummy application only uses HighVoltage's controller and templates, so stop drawing the unused engine route instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
tricknotes
force-pushed
the
fix-rails-deprecations
branch
from
September 4, 2026 08:58
838b557 to
dd574bf
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Rails 8.1 CI jobs emit two kinds of deprecation warnings (e.g. this job):
config.active_support.to_time_preserves_timezoneis deprecated and will be removed in Rails 8.2 — preserving the timezone is the only behavior on 8.1, so the dummy application now assigns the setting only on older Rails versions.get received a hash argument as/get received a hash argument /pages/*id— this comes from HighVoltage's/pages/*idengine route, which is still defined with the deprecated hash-argument style (its latest release, 5.0.0, included). The gem's ownmount_ember_apppasses keywords and is not affected. The dummy application only uses HighVoltage's controller and templates, not the engine route, so it stops drawing it viaHighVoltage.configure { |config| config.routes = false }.Verification
spec/libpasses under 8.1.