Run CI for pull requests against any base branch - #657
Merged
Conversation
The pull_request trigger filtered base branches with `branches: "*"`, but the `*` glob does not match `/`, so a pull request whose base branch name contains a slash (a stacked pull request, for instance) silently got no CI runs at all. Drop the filter: an unfiltered pull_request trigger already means every base branch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
pull_requesttrigger filtered base branches withbranches: "*", but the*glob does not match/, so a pull request whose base branch name contains a slash silently gets no CI runs at all. This is why #654 stopped getting runs the moment its base was retargeted toclaude/vite-dev-server-hmr-y3xm8i, while pull requests based onmainkept running.Drop the filter: an unfiltered
pull_requesttrigger already means every base branch, which is what"*"was evidently meant to express.Notes
pull_requestevents is read from the merge ref), e.g. by merging main into the Serve Vite-based Ember apps from development server #653 branch after this lands.🤖 Generated with Claude Code