Repository navigation
Include errors in logging - #854
Merged
Merged
Conversation
mhutchinson
requested review from
phbnf and
roger2hk
and removed request for
a team
May 11, 2026 09:06
This fixes transparency-dev#850 by ensuring that error types are converted into JSON-serializable strings. I can't think of other types than error where we'd log something that isn't a string/int primitive, but if needed, more can be added here.
mhutchinson
force-pushed
the
feat/errMessages
branch
from
May 11, 2026 09:08
47b28d9 to
afa20b2
Compare
phbnf
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #850 by ensuring that error types are converted into JSON-serializable strings. I can't think of other types than error where we'd log something that isn't a string/int primitive, but if needed, more can be added here.