fix(qdrant): add query_points and query_batch_points to async client instrumentation#4196
fix(qdrant): add query_points and query_batch_points to async client instrumentation#4196william-xue wants to merge 1 commit into
Conversation
…instrumentation The sync QdrantClient had query_points and query_batch_points in its instrumentation config, but AsyncQdrantClient was missing both methods. This caused async users to not get spans for these operations. Closes traceloop#3492
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe instrumentation configuration for Qdrant's async client is extended with two new method-to-span mappings: ChangesAsync Qdrant client instrumentation extensions
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
xueyuan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Summary
The sync
QdrantClientinstrumentation includesquery_pointsandquery_batch_pointsin its method config, but the asyncAsyncQdrantClientconfig was missing both. This means async users get no tracing spans when calling these methods.This PR adds the two missing entries to
async_qdrant_client_methods.json, bringing async instrumentation to parity with the sync client.The instrumentor already uses
hasattrchecks (line 55 in__init__.py), so this is safe across all qdrant-client versions — if a version doesn't have these methods, they're silently skipped.Changes
query_pointsandquery_batch_pointstoasync_qdrant_client_methods.jsonTest plan
pytest tests/ -vAsyncQdrantClienthas bothquery_pointsandquery_batch_pointsmethods (qdrant-client 1.18.0)Related issues
opentelemetry-instrumentation-qdrantis incompatible withqdrant-clientversion1.16.1#3492 (follow-up on async coverage gap noted in this comment)Summary by CodeRabbit