Skip to content

feat(instrumentation-ollama): add duration telemetry span attributes #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Saptami191 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(instrumentation-ollama): add duration telemetry span attributes #4194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions ...s/opentelemetry-instrumentation-ollama/opentelemetry/instrumentation/ollama/span_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,30 @@ def set_model_response_attributes(span, token_histogram, llm_request_type, respo
)
_set_span_attribute(span, GenAIAttributes.GEN_AI_SYSTEM, "Ollama")

_set_span_attribute(
span,
"llm.ollama.total_duration",
response.get("total_duration"),
)

_set_span_attribute(
span,
"llm.ollama.load_duration",
response.get("load_duration"),
)

_set_span_attribute(
span,
"llm.ollama.prompt_eval_duration",
response.get("prompt_eval_duration"),
)

_set_span_attribute(
span,
"llm.ollama.eval_duration",
response.get("eval_duration"),
)

if (
token_histogram is not None
and isinstance(input_tokens, int)
Expand Down
16 changes: 16 additions & 0 deletions packages/opentelemetry-instrumentation-ollama/tests/test_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ def test_ollama_generation_legacy(
GenAIAttributes.GEN_AI_USAGE_OUTPUT_TOKENS
) + ollama_span.attributes.get(GenAIAttributes.GEN_AI_USAGE_INPUT_TOKENS)

assert ollama_span.attributes.get("llm.ollama.total_duration") > 0

assert ollama_span.attributes.get("llm.ollama.load_duration") > 0

assert ollama_span.attributes.get("llm.ollama.prompt_eval_duration") > 0

assert ollama_span.attributes.get("llm.ollama.eval_duration") > 0

logs = log_exporter.get_finished_logs()
assert (
len(logs) == 0
Expand Down Expand Up @@ -162,6 +170,14 @@ def test_ollama_streaming_generation_legacy(
GenAIAttributes.GEN_AI_USAGE_OUTPUT_TOKENS
) + ollama_span.attributes.get(GenAIAttributes.GEN_AI_USAGE_INPUT_TOKENS)

assert ollama_span.attributes.get("llm.ollama.total_duration") > 0

assert ollama_span.attributes.get("llm.ollama.load_duration") > 0

assert ollama_span.attributes.get("llm.ollama.prompt_eval_duration") > 0

assert ollama_span.attributes.get("llm.ollama.eval_duration") > 0

logs = log_exporter.get_finished_logs()
assert (
len(logs) == 0
Expand Down