-
Notifications
You must be signed in to change notification settings - Fork 486
feat: add DISTINCT ON support for PostgreSQL. #2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VladislavYar
wants to merge
2
commits into
tortoise:develop
Choose a base branch
from
VladislavYar:distinct-by-specific-fields
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,204 @@ | ||
| import pytest | ||
|
|
||
| from tests.testmodels import Tournament | ||
| from tortoise.contrib import test | ||
| from tortoise.exceptions import OperationalError | ||
|
|
||
| # --------------------------------------------------------------------------- | ||
| # Basic DISTINCT (all databases) | ||
| # --------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_distinct_no_args(db): | ||
| await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="b") | ||
| tournaments = await Tournament.all().distinct() | ||
| assert len(tournaments) == 2 | ||
|
|
||
|
|
||
| # --------------------------------------------------------------------------- | ||
| # DISTINCT ON (PostgreSQL only) | ||
| # --------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_single_field(db): | ||
| tournament_1 = await Tournament.create(name="1", desc="1") | ||
| await Tournament.create(name="1", desc="2") | ||
| await Tournament.create(name="1", desc="3") | ||
|
|
||
| tournaments = await Tournament.all().distinct("name") | ||
| assert tournaments == [tournament_1] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_single_field_with_order_by(db): | ||
| await Tournament.create(name="1", desc="1") | ||
| await Tournament.create(name="1", desc="2") | ||
| tournament_3 = await Tournament.create(name="1", desc="3") | ||
|
|
||
| tournaments = await Tournament.all().distinct("name").order_by("name", "-desc") | ||
| assert tournaments == [tournament_3] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_multiple_fields(db): | ||
| tournament_1 = await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="a") | ||
| tournament_3 = await Tournament.create(name="2", desc="b") | ||
|
|
||
| tournaments = await Tournament.all().distinct("name", "desc").order_by("name", "desc") | ||
| assert tournaments == [tournament_1, tournament_3] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_values_list_single_field(db): | ||
| """values_list selects one field, same as DISTINCT ON field.""" | ||
| await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="b") | ||
| await Tournament.create(name="2", desc="c") | ||
|
|
||
| tournaments = await Tournament.all().distinct("name").values_list("name", flat=True) | ||
| assert tournaments == ["1", "2"] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_values_list_multiple_fields(db): | ||
| await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="b") | ||
| await Tournament.create(name="2", desc="c") | ||
|
|
||
| tournaments = await Tournament.all().distinct("name").values_list("name", "desc") | ||
| assert tournaments == [("1", "a"), ("2", "c")] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_values_list_extra_fields(db): | ||
| await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="b") | ||
| await Tournament.create(name="2", desc="c") | ||
|
|
||
| tournaments = await Tournament.all().distinct("name").values_list("desc", flat=True) | ||
| assert tournaments == ["a", "c"] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_values_list_extra_field_respects_order_by(db): | ||
| await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="b") | ||
| await Tournament.create(name="2", desc="c") | ||
|
|
||
| tournaments = ( | ||
| await Tournament.all() | ||
| .distinct("name") | ||
| .order_by("name", "-desc") | ||
| .values_list("desc", flat=True) | ||
| ) | ||
| assert tournaments == ["b", "c"] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_values_single_field(db): | ||
| await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="b") | ||
| await Tournament.create(name="2", desc="c") | ||
|
|
||
| tournaments = await Tournament.all().distinct("name").values("name") | ||
| assert tournaments == [{"name": "1"}, {"name": "2"}] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_values_multiple_fields(db): | ||
| await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="b") | ||
| await Tournament.create(name="2", desc="c") | ||
|
|
||
| tournaments = await Tournament.all().distinct("name").values("name", "desc") | ||
| assert tournaments == [{"name": "1", "desc": "a"}, {"name": "2", "desc": "c"}] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_values_extra_fields(db): | ||
| await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="b") | ||
| await Tournament.create(name="2", desc="c") | ||
|
|
||
| tournaments = await Tournament.all().distinct("name").values("desc") | ||
| assert tournaments == [{"desc": "a"}, {"desc": "c"}] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_values_extra_field_respects_order_by(db): | ||
| await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="b") | ||
| await Tournament.create(name="2", desc="c") | ||
|
|
||
| tournaments = await Tournament.all().distinct("name").order_by("name", "-desc").values("desc") | ||
| assert tournaments == [{"desc": "b"}, {"desc": "c"}] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_only_same_field(db): | ||
| await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="b") | ||
| await Tournament.create(name="2", desc="c") | ||
|
|
||
| tournaments = await Tournament.all().distinct("name").only("name") | ||
| assert [t.name for t in tournaments] == ["1", "2"] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_only_extra_field(db): | ||
| await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="b") | ||
| await Tournament.create(name="2", desc="c") | ||
|
|
||
| tournaments = await Tournament.all().distinct("name").only("name", "desc") | ||
| assert [(t.name, t.desc) for t in tournaments] == [("1", "a"), ("2", "c")] | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_only_with_order_by(db): | ||
| await Tournament.create(name="1", desc="a") | ||
| await Tournament.create(name="1", desc="b") | ||
| await Tournament.create(name="2", desc="c") | ||
|
|
||
| tournaments = ( | ||
| await Tournament.all().distinct("name").order_by("name", "-desc").only("name", "desc") | ||
| ) | ||
| assert [(t.name, t.desc) for t in tournaments] == [("1", "b"), ("2", "c")] | ||
|
|
||
|
|
||
| # --------------------------------------------------------------------------- | ||
| # DISTINCT ON validation errors | ||
| # --------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| @test.requireCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_invalid_order_by(db): | ||
| await Tournament.create(name="1") | ||
| with pytest.raises(OperationalError): | ||
| await Tournament.all().distinct("name").order_by("desc") | ||
|
|
||
|
|
||
| @test.skipCapability(dialect="postgres") | ||
| @pytest.mark.asyncio | ||
| async def test_distinct_on_not_supported_outside_postgres(db): | ||
| with pytest.raises(OperationalError): | ||
| Tournament.all().distinct("name") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.