Skip to content

_HasFileno in platform/asyncio.py must be hashable because instances are used as dictionary key #3622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathandung wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −4
Open

_HasFileno in platform/asyncio.py must be hashable because instances are used as dictionary key #3622

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ebf833
commit
jonathandung May 13, 2026
2dcf11e
add blank line
jonathandung May 21, 2026
e9a08f8
add type ignores
jonathandung May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tornado/platform/asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ class _HasFileno(Protocol):
def fileno(self) -> int:
pass

def __hash__(self) -> int:
pass


_FileDescriptorLike = Union[int, _HasFileno]

Expand Down Expand Up @@ -727,22 +730,22 @@ def close(self) -> None:

def add_reader(
self,
fd: "_FileDescriptorLike",
fd: "_FileDescriptorLike", # type: ignore[override]
callback: Callable[..., None],
*args: "Unpack[_Ts]",
) -> None:
return self._selector.add_reader(fd, callback, *args)

def add_writer(
self,
fd: "_FileDescriptorLike",
fd: "_FileDescriptorLike", # type: ignore[override]
callback: Callable[..., None],
*args: "Unpack[_Ts]",
) -> None:
return self._selector.add_writer(fd, callback, *args)

def remove_reader(self, fd: "_FileDescriptorLike") -> bool:
def remove_reader(self, fd: "_FileDescriptorLike") -> bool: # type: ignore[override]
return self._selector.remove_reader(fd)

def remove_writer(self, fd: "_FileDescriptorLike") -> bool:
def remove_writer(self, fd: "_FileDescriptorLike") -> bool: # type: ignore[override]
return self._selector.remove_writer(fd)
Loading