You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the second commit, the recommendation in curl's docs is to replace socket_all() with socket_action(), but I'm guessing a bit as to how exactly that should work; I'm not very familiar with (py)curl.
For the second commit, the use of socket_all instead of socket_timeout was originally deliberate. In 2010 there were bugs in which libcurl's internal timeout bookkeeping would lose track of a socket, and so we put in a periodic call to socket_all to force it to check everything again. Calling socket_action(SOCKET_TIMEOUT) is already done in handle_timeout, so doing it again in handle_force_timeout is redundant (assuming this logic in handle_timeout to handle differences between clock implementations is doing its job).
I think at this point I'm comfortable deleting everything related to force_timeout here. In 2010 we were kind of on the cutting edge of async libcurl usage and would run into a lot of bugs. But since then, aside from the general increasing maturity of libcurl, it's also been through a major refactoring (in 2013) so that the synchronous interfaces are implemented in terms of the async ones, so that class of bugs is less likely to go unnoticed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were failing with pycurl 7.46 because of a deprecationwarning with IOCTLFUNCTION. The suggested replacement is SEEKFUNCTION.