Skip to content

kaizen for diskInfoImpl.Export #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skoya76 merged 2 commits into from
May 1, 2026
Merged

kaizen for diskInfoImpl.Export #172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7cd734
add error log for failed metrics POST retries
ushitora-anqou Apr 28, 2026
700b692
close response body from metrics POST
ushitora-anqou Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion probe/exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package probe
import (
"bytes"
"encoding/json"
"log"
"net/http"
"time"

Expand Down Expand Up @@ -45,11 +46,14 @@ func (di *diskInfoImpl) Export(metrics *DiskMetrics) error {
return err
}

var resp *http.Response
for retryCounter := 0; retryCounter < maxRetryCount; retryCounter++ {
_, err = http.Post(di.url, "application/json", bytes.NewReader(s))
resp, err = http.Post(di.url, "application/json", bytes.NewReader(s))
if err == nil {
Comment on lines +51 to 52
Copy link
Copy Markdown
Contributor

@molpako molpako Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we check err before touching resp.Body.Close()?
resp can be nil on request errors.

Copy link
Copy Markdown
Member Author

@ushitora-anqou ushitora-anqou Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I'll fix this.

_ = resp.Body.Close()
return nil
}
log.Printf("failed to post data: %v", err)
time.Sleep(time.Second * retryIntervalSec)
}

Expand Down