Release v4.1.0#119
Merged
Merged
Conversation
- ResampleReactantsPosition- potential crash in zero-diffusion cases is fixed. For that, early-return added for D1 == 0 or D2 == 0 prevent divide-by-zero/NaNs. - Conversion in background contact reaction is fixed. Concentration is now multiplied by Avogadro*1e-24 at processes/TsIRTConfiguration.cc:817. - Fixed a guard for type II/IV diffusion-limit. In ResolveReactionParameters (around lines ~481–497), now sim aborts with a descriptive message when kobs >= kdiff (preventing infinite kact/bad probabilities). - Fix missing Avogadro in background product placement, GetBackgroundPositionOfProducts used kobs/(4*pi*2*D1); current code includes * CLHEP::Avogadro and a dummy kobs for negatives (lines ~726–742). - Misleading “Re-set charge” in printing logs. At processes/TsIRTConfiguration.cc:101-108, the message prints the radius instead of the charge when overriding Mo/*/Charge. - Fix molecule ID when reuse it and counting it. In AddMolecule (~lines 383–393), fLastMoleculeID is set to the provided moleculeID, which can rewind the counter, so we use max of both values so that users can set moleculeID to any number (e.g., 104) - GetH2SO4ComponentsConcentrationP out-of-bounds risk is fixed. Previously the loop iterated over map Result and accessesed Result[i+1] without bounds check (~lines 970–975). modified: processes/TsIRT.cc modified: processes/TsIRTConfiguration.cc
New nomenclature of Geant4-DNA caused incompatiblity in molecule naming, a map to translate names was added - There is a time penalty, so this is still under improvement - TODO Printing reactions happened multiple times due to double declaration of pointers of TsIRTConfiguration modified: processes/TsEmDNAPhysics.cc modified: processes/TsIRT.cc modified: processes/TsIRT.hh modified: processes/TsIRTConfiguration.cc modified: processes/TsIRTConfiguration.hh modified: processes/TsIRTContinuous.cc modified: processes/TsIRTContinuous.hh modified: processes/TsVIRTProcedure.cc
modified: processes/TsIRTConfiguration.cc modified: processes/TsIRTConfiguration.hh
modified: processes/TsIRT.cc modified: processes/TsIRTContinuous.cc
modified: README.md modified: processes/TsEmDNAPhysics.cc modified: processes/TsEmDNAPhysics.hh modified: processes/TsIRT.cc modified: processes/TsIRTConfiguration.cc
Updated dataset versions for Geant4 EMLOW and ENSDFSTATE in CI workflow. Signed-off-by: JoseRamosMendez <joserm84@gmail.com>
Signed-off-by: Thongchai Masilela <159175671+tmasilela@users.noreply.github.com>
JoseRamosMendez
added a commit
that referenced
this pull request
Feb 27, 2026
Merge pull request #119 from topas-nbio/develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v4.1.0