Conversation
bradjc
force-pushed
the
dev/ywf-remaining
branch
from
7295c63 to
b0c05bd
Compare
Using YWF with alarm is more nuanced because users might reasonably expect to have both periodic timers and do a delay_ms.
Contributor
Author
|
I reverted the changes to alarm.c as alarm needs more thought. |
Contributor
Author
|
Ok I've tested a bunch of these, including the sensors using the hail app and the kv test app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly done with Claude.
Want to see what happens with CI, and then try to test some of these changes.