Refactor: make dialect in build_formatted_time optional, fetch it from parser#7639
Merged
Conversation
georgesittas
force-pushed
the
jo/refactor_build_formatted_time
branch
from
6a11bc8 to
b307ad6
Compare
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallsqlglot:cold-prql-test: 101037 total, 101036 passed (pass rate: 100.0%), sqlglot version: sqlglot:jo/refactor_build_formatted_time: 113210 total, 112112 passed (pass rate: 99.0%), sqlglot version: Transitions: Dialect pair changes: 3 previous results not found, 0 current results not found ✅ 61 test(s) passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #7626 (comment)