Skip to content

fix(annotate_types)!: propagate type through IgnoreNulls/RespectNulls wrappers [CLAUDE] #7636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 2 commits into from
May 12, 2026
+15 −2
Merged

fix(annotate_types)!: propagate type through IgnoreNulls/RespectNulls wrappers [CLAUDE] #7636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4685466
test(annotate_types): add failing tests for IgnoreNulls/RespectNulls …
RichardHughes-amp May 11, 2026
01a95f3
fix(annotate_types): propagate type through IgnoreNulls/RespectNulls …
RichardHughes-amp May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sqlglot/typing/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@
},
**{
expr_type: {"annotator": lambda self, e: self._annotate_unary(e)}
for expr_type in subclasses(exp.__name__, (exp.Unary, exp.Alias))
for expr_type in subclasses(
exp.__name__, (exp.Unary, exp.Alias, exp.IgnoreNulls, exp.RespectNulls)
)
},
**{
expr_type: {"returns": exp.DType.BIGINT}
Expand Down
13 changes: 12 additions & 1 deletion tests/fixtures/optimizer/annotate_functions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6375,4 +6375,15 @@ VARCHAR;

# dialect: clickhouse
MD5(tbl.str_col);
FIXEDSTRING(16);
FIXEDSTRING(16);
--------------------------------------
-- IGNORE NULLS / RESPECT NULLS
--------------------------------------

# dialect: spark, databricks, snowflake, bigquery, trino, redshift
FIRST_VALUE(tbl.str_col) IGNORE NULLS;
TEXT;

# dialect: spark, databricks, snowflake, bigquery, trino, redshift
LAST_VALUE(tbl.str_col) RESPECT NULLS;
TEXT;
Loading