Makes monomorphic all words listed in #184. - #232
Merged
Conversation
Contributor
Author
|
This PR fully addresses #184 and would allow it to be closed. |
Contributor
Author
|
There— according to the script I just wrote to check, I've no longer missed any. |
este-rs
approved these changes
Jun 25, 2026
For consistency— "naraq" is the only word who's definition has the US spelling.
Contributor
Author
|
Is anyone opposed to me merging this (i.e. ousting the last bits of valency polymorphism)? |
This was referenced Jul 6, 2026
dembim
added
frame
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty substantial change, but one that I think we all can agree on. If you take issue with any detail of this change, please discuss below. Since the diff is fairly large for a PR against toaq/dictionary, I'm requesting multiple reviews, but as I've said, I think merging this (or a minor revision of it) is a relative no-brainer given the apparent trajectory of the community with respect to valency polymorphism.
Closes #184