Fix Android dynamicanimation dependency lock - #6278
Draft
wca4a wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the missing
androidx.dynamicanimation:dynamicanimation-ktx:1.1.0entry to the Android Gradle dependency lock.Changes
apps/tlon-mobile/android/app/gradle.lockfilewith the repository's documentedpnpm run android:update-lockfilecommand.How did I test?
Reproduced the failure while building the Android
productionDebugclient:Ran
ANDROID_HOME=/Users/williamarzt/Library/Android/sdk pnpm run android:update-lockfilesuccessfully.Ran
./gradlew app:dependencies --configuration productionDebugRuntimeClasspathsuccessfully with the regenerated lock.Continued the Android native build past
:app:processProductionDebugResources, the point blocked by the stale lock.Risks and impact
Low. This only records an already-resolved transitive dependency in Gradle's lock state; it does not change application code or request a different dependency version.
This was discovered while building the Buckets client, but it is already reproducible on
develop, so it is intentionally separate from the Buckets product PR.The later local
/private/tmpversus/tmpCMake path mismatch was specific to building from a macOS symlinked temporary checkout and is not included here.Rollback plan
Revert this commit to restore the previous lockfile.