Fix KeyError for newer Apple Silicon chips (M3/M4/M5)#88
Open
akashicMarga wants to merge 1 commit intotlkh:mainfrom
Open
Fix KeyError for newer Apple Silicon chips (M3/M4/M5)#88akashicMarga wants to merge 1 commit intotlkh:mainfrom
akashicMarga wants to merge 1 commit intotlkh:mainfrom
Conversation
Replace hardcoded E0/E1/P0/P1 cluster name lookups with dynamic detection that averages all available E-Cluster and P-Cluster entries. This fixes crashes on M3, M4, M5 and any future chips that report different cluster naming conventions. Tested on Apple M5 Pro.
|
macOS 26.4 changed powermetrics return value from "P-Cluster" to "S-Cluster" for m5. I don't know if M1-M4 still using "P-Cluster", can you fix that? |
|
@akashicMarga I pip installed your branch with the fix and works for me again under macos 26.4, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded E0/E1/P0/P1 cluster name lookups with dynamic detection that averages all available E-Cluster and P-Cluster entries. This fixes crashes on M3, M4, M5 and any future chips that report different cluster naming conventions.
Tested on Apple M5 Pro.