Repository navigation
Conversation
… a YubiKey PIV slot. Co-authored-by: Turnkey <noreply@turnkey.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A profile can now sign Turnkey requests with a P256 key generated in any signing PIV slot of a YubiKey, so each API request needs a physical touch.
tkrefuses keys that were imported, need the PIN, or sign without a touch.Public API changes
profile creategains--yubikey-slot SLOTand--yubikey-serial SERIAL.api_key_fileor ayubikeytable (serial,slot,public_key).session requestrefuses YubiKey profiles.yubikeyCargo feature, off by default. Only the macOS release binary enables it, because the static musl builds can't link PC/SC.Review focus
never.always, polling commands such asactivity waitneed one touch per request. The docs recommendcached.Stamponly returns string errors, so device errors are flattened intoStamperError.Testing
Added unit and CLI parsing tests.