Repository navigation
Document the Git 2.54 requirement of the co-author hook - #92
Merged
Merged
Conversation
… with git hook list, and assert that check in the e2e suite. Co-authored-by: Turnkey <noreply@turnkey.com>
emostov
marked this pull request as ready for review
October 16, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a stock Mac the co-author hook silently does nothing: Git older than 2.54, including macOS's
/usr/bin/git(2.50), ignores config-based hooks without an error. Testing v0.7.0 in the Hermes agent harness hit this, because Hermes puts/usr/binahead of Homebrew on its terminal'sPATH, so commits were signed but had no trailer.Public API changes
None. The co-author docs now show
git hook list commit-msgas the check that Git runs the hook, and state the 2.54 requirement. The signing skill's step 7 tells the agent to run that check.Review focus
tkshould also warn at signing time when the trailer is missing, rather than relying on docs.Testing
Extended e2e tests.