Repository navigation
chore(build): move to JDK 21 LTS and Kotlin 2.4.21 - #101
Open
tkhq-valet-dev[bot] wants to merge 1 commit into
Open
tkhq-valet-dev[bot] wants to merge 1 commit into
tkhq-valet-dev[bot] wants to merge 1 commit into
Conversation
Replace unsupported Temurin JDK 22/24 in CI with JDK 21 (LTS); Gradle 8.14 cannot run on JDK 25. Bump Kotlin 2.2.20 -> 2.4.21 (supports Gradle 7.6.3-9.7.0, AGP 8.5.2-9.3.1). Migrate demo wallet kotlinOptions to compilerOptions DSL. No trust-store changes: OkHttp uses platform/JDK default trust.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unsupported build toolchain versions (CA/security-runtime review, per Mehdi Sabraoui).
kotlinOptions { jvmTarget }removed in 2.4 ->kotlin { compilerOptions }.Verified locally on JDK 21: encoding/crypto/types build+test, tools test,
generate(no diff), Android libs compileReleaseKotlin. assembleRelease/demo wallet not run locally (aarch64 sandbox, x86 aapt2); CI should cover.Note: Gradle 8.14 emits a KGP deprecation warning (min 8.14.4 in Kotlin 2.5); not addressed here.