Gateway with ldap authentication #3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,211 @@ | ||
| /* | ||
| Copyright 2024 BlackRock, Inc. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package auth | ||
|
|
||
| import ( | ||
| "crypto/tls" | ||
| "encoding/base64" | ||
| "fmt" | ||
| "net/http" | ||
| "strings" | ||
|
|
||
| "github.com/go-ldap/ldap/v3" | ||
| "github.com/tinymultiverse/tinyapp/gateway/internal" | ||
| "go.uber.org/zap" | ||
| ) | ||
|
|
||
| type LDAPAuthenticator struct { | ||
| config internal.EnvVars | ||
| } | ||
|
|
||
| func NewLDAPAuthenticator(config internal.EnvVars) *LDAPAuthenticator { | ||
| return &LDAPAuthenticator{ | ||
| config: config, | ||
| } | ||
| } | ||
|
|
||
| // Authenticate performs only LDAP authentication without authorization | ||
|
jk4102 marked this conversation as resolved.
Outdated
|
||
| func (la *LDAPAuthenticator) Authenticate(req *http.Request) (string, error) { | ||
| if !la.config.LdapEnabled { | ||
| return "", nil // LDAP is disabled, skip authentication | ||
| } | ||
|
|
||
| // Extract credentials from Authorization header | ||
| username, password, err := la.extractCredentials(req) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
||
| // Authenticate against LDAP | ||
| return la.authenticateLDAP(username, password) | ||
| } | ||
|
|
||
| // AuthorizeUser checks if the authenticated user is in the allowed users list | ||
| func (la *LDAPAuthenticator) AuthorizeUser(username string) error { | ||
| return la.authorizeUser(username) | ||
| } | ||
|
|
||
| // extractCredentials extracts username and password from Basic Auth header | ||
| func (la *LDAPAuthenticator) extractCredentials(req *http.Request) (string, string, error) { | ||
|
jk4102 marked this conversation as resolved.
Outdated
|
||
| authHeader := req.Header.Get("Authorization") | ||
| if authHeader == "" { | ||
| return "", "", fmt.Errorf("missing Authorization header") | ||
| } | ||
|
|
||
| if !strings.HasPrefix(authHeader, "Basic ") { | ||
| return "", "", fmt.Errorf("unsupported authorization type") | ||
| } | ||
|
|
||
| // Decode base64 credentials | ||
| encoded := strings.TrimPrefix(authHeader, "Basic ") | ||
| decoded, err := base64.StdEncoding.DecodeString(encoded) | ||
| if err != nil { | ||
| return "", "", fmt.Errorf("invalid base64 encoding: %w", err) | ||
| } | ||
|
|
||
| // Split username and password | ||
| credentials := strings.SplitN(string(decoded), ":", 2) | ||
| if len(credentials) != 2 { | ||
| return "", "", fmt.Errorf("invalid credentials format") | ||
| } | ||
|
|
||
| return credentials[0], credentials[1], nil | ||
| } | ||
|
|
||
| // authenticateLDAP performs LDAP authentication | ||
| func (la *LDAPAuthenticator) authenticateLDAP(username, password string) (string, error) { | ||
| // Connect to LDAP server | ||
| conn, err := la.connectLDAP() | ||
|
Member
There was a problem hiding this comment. can we keep connection open globally (check concurrency support)
Member
Author
There was a problem hiding this comment. same as jupyterlab version - concurrency not built in |
||
| if err != nil { | ||
| return "", fmt.Errorf("failed to connect to LDAP server: %w", err) | ||
| } | ||
| defer conn.Close() | ||
|
|
||
| // Bind with service account if configured | ||
| if la.config.LdapBindDN != "" { | ||
| err = conn.Bind(la.config.LdapBindDN, la.config.LdapBindPassword) | ||
| if err != nil { | ||
| zap.S().Errorw("failed to bind with service account", "error", err) | ||
|
jk4102 marked this conversation as resolved.
Outdated
|
||
| return "", fmt.Errorf("LDAP service account bind failed") | ||
| } | ||
| } | ||
|
|
||
| // Search for user | ||
| userDN, err := la.searchUser(conn, username) | ||
| if err != nil { | ||
| return "", fmt.Errorf("user search failed: %w", err) | ||
| } | ||
|
|
||
| // Authenticate user by binding with their credentials | ||
| err = conn.Bind(userDN, password) | ||
| if err != nil { | ||
| zap.S().Debugw("user authentication failed", "username", username, "error", err) | ||
|
jk4102 marked this conversation as resolved.
Outdated
|
||
| return "", fmt.Errorf("authentication failed") | ||
| } | ||
|
|
||
| zap.S().Infow("user authenticated successfully", "username", username) | ||
| return username, nil | ||
| } | ||
|
|
||
| // connectLDAP establishes connection to LDAP server | ||
| func (la *LDAPAuthenticator) connectLDAP() (*ldap.Conn, error) { | ||
| address := fmt.Sprintf("%s:%d", la.config.LdapServer, la.config.LdapPort) | ||
| fmt.Println("Connecting to LDAP server at", address) | ||
|
|
||
| var conn *ldap.Conn | ||
| var err error | ||
|
|
||
| if la.config.LdapTLS { | ||
| tlsConfig := &tls.Config{ | ||
| ServerName: la.config.LdapServer, | ||
| } | ||
| conn, err = ldap.DialTLS("tcp", address, tlsConfig) | ||
| } else { | ||
| conn, err = ldap.Dial("tcp", address) | ||
| } | ||
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return conn, nil | ||
| } | ||
|
|
||
| // searchUser searches for user in LDAP directory | ||
| func (la *LDAPAuthenticator) searchUser(conn *ldap.Conn, username string) (string, error) { | ||
| // Build search filter | ||
| filter := fmt.Sprintf("(&(%s=%s)%s)", | ||
| la.config.LdapUserAttribute, | ||
| ldap.EscapeFilter(username), | ||
| la.config.LdapUserFilter) | ||
|
|
||
| // Perform search | ||
| searchRequest := ldap.NewSearchRequest( | ||
| la.config.LdapBaseDN, | ||
| ldap.ScopeWholeSubtree, | ||
| ldap.NeverDerefAliases, | ||
| 1, // Size limit | ||
| 0, // Time limit | ||
| false, // Types only | ||
| filter, | ||
| []string{"dn"}, // Attributes to return | ||
|
jk4102 marked this conversation as resolved.
Outdated
|
||
| nil, // Controls | ||
| ) | ||
|
|
||
| result, err := conn.Search(searchRequest) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
||
| if len(result.Entries) == 0 { | ||
| return "", fmt.Errorf("user not found") | ||
| } | ||
|
|
||
| if len(result.Entries) > 1 { | ||
| return "", fmt.Errorf("multiple users found") | ||
| } | ||
|
|
||
| return result.Entries[0].DN, nil | ||
| } | ||
|
|
||
| // RequireAuth is a middleware that sends 401 with WWW-Authenticate header | ||
| func (la *LDAPAuthenticator) RequireAuth(w http.ResponseWriter) { | ||
| w.Header().Set("WWW-Authenticate", `Basic realm="LDAP Authentication"`) | ||
| w.WriteHeader(http.StatusUnauthorized) | ||
| w.Write([]byte("Unauthorized")) | ||
| } | ||
|
|
||
| // authorizeUser checks if the authenticated user is in the allowed users list | ||
| func (la *LDAPAuthenticator) authorizeUser(username string) error { | ||
| if !la.config.AuthorizationEnabled { | ||
| return nil // Authorization is disabled, allow all authenticated users | ||
| } | ||
|
|
||
| if len(la.config.AllowedUsers) == 0 { | ||
| return nil // No restrictions if allowed users list is empty | ||
| } | ||
|
|
||
| for _, allowedUser := range la.config.AllowedUsers { | ||
| if strings.TrimSpace(allowedUser) == username { | ||
| zap.S().Debugw("user authorized", "username", username) | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| zap.S().Warnw("user not in allowed users list", "username", username, "allowedUsers", la.config.AllowedUsers) | ||
|
jk4102 marked this conversation as resolved.
Outdated
|
||
| return fmt.Errorf("user not authorized") | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.