Skip to content

Fix ScheduleType.schedule_sub_type reading the wrong JSON key #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timmo001 merged 2 commits into from
Aug 10, 2026
Merged

Fix ScheduleType.schedule_sub_type reading the wrong JSON key #166

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d2fef
Fix ScheduleType.schedule_sub_type reading the wrong JSON key
clutch2sft Jul 21, 2026
dc955a9
Support both scheduleSubType and scheduleSubtype keys
clutch2sft Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aiolyric/objects/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def schedule_type(self):
@property
def schedule_sub_type(self):
"""Return the schedule sub type."""
return self.attributes.get("scheduleSubType", None)
return self.attributes.get("scheduleSubtype", None)


class SettingsHardwareSettings(LyricBaseObject):
Expand Down
4 changes: 2 additions & 2 deletions tests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"availableScheduleTypes": ["None", "Geofenced", "TimedEmea"],
"schedulableFan": False,
},
"scheduleType": {"scheduleType": "Timed", "scheduleSubType": "EMEA"},
"scheduleType": {"scheduleType": "Timed", "scheduleSubtype": "EMEA"},
"scheduleStatus": "Resume",
"allowedTimeIncrements": 10,
"settings": {
Expand Down Expand Up @@ -80,7 +80,7 @@
"availableScheduleTypes": ["None", "Geofenced", "TimedEmea"],
"schedulableFan": False,
},
"scheduleType": {"scheduleType": "Timed", "scheduleSubType": "EMEA"},
"scheduleType": {"scheduleType": "Timed", "scheduleSubtype": "EMEA"},
"scheduleStatus": "Resume",
"allowedTimeIncrements": 10,
"settings": {
Expand Down
2 changes: 1 addition & 1 deletion tests/objects/test_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def test_device(
)
assert (
obj.schedule_type.schedule_sub_type
== device_fixture_response["scheduleType"]["scheduleSubType"]
== device_fixture_response["scheduleType"]["scheduleSubtype"]
)
assert obj.schedule_status == device_fixture_response["scheduleStatus"]
assert (
Expand Down
2 changes: 1 addition & 1 deletion tests/objects/test_location.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def test_location(
)
assert (
obj.devices[0].schedule_type.schedule_sub_type
== location_fixture_response["devices"][0]["scheduleType"]["scheduleSubType"]
== location_fixture_response["devices"][0]["scheduleType"]["scheduleSubtype"]
)
assert (
obj.devices[0].schedule_status
Expand Down
Loading