Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the existing SearchBar component by adding autocomplete suggestions backed by a debounced, cancellable API call, improving search UX while the user types.
Changes:
- Replaces the plain search input with
@base-ui/react/autocomplete-based UI for rendering and selecting suggestions. - Adds a 250ms debounce layer and fetches suggestions via
react-query, passing anAbortSignalfor cancellation. - Updates
getSearchSuggestionsto accept an optionalAbortSignaland forward it to$api.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib/components/SearchBar.tsx | Adds debounced suggestion fetching and renders an autocomplete dropdown with clear/search interactions. |
| src/lib/api/discovery.ts | Extends getSearchSuggestions to accept an optional AbortSignal for request cancellation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+24
to
+28
| const isWaiting = Boolean(query.trim()) && query.trim() !== debouncedQuery | ||
| const suggestions = isWaiting | ||
| ? [] | ||
| : suggestionsQuery.data?.collection ?? [] | ||
|
|
Comment on lines
39
to
42
| onSubmit={(e) => { | ||
| e.preventDefault() | ||
| navigate({ | ||
| to: '/search', | ||
| search: { q: query }, | ||
| }) | ||
| search(query) | ||
| }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.