Keep abundant per category as an alternative filtering method#341
Open
gaoyingnan-academic wants to merge 4 commits intotidyomics:masterfrom
Open
Keep abundant per category as an alternative filtering method#341gaoyingnan-academic wants to merge 4 commits intotidyomics:masterfrom
gaoyingnan-academic wants to merge 4 commits intotidyomics:masterfrom
Conversation
Initial commit for experimental filtering functions.
Automatically generated updates on documentation.
Bump version by 0.0.1
stemangiola
reviewed
May 5, 2026
Collaborator
stemangiola
left a comment
stemangiola
left a comment
There was a problem hiding this comment.
Thanks Yingnan, we always build unit tests along with every PR
Copilot AI
added a commit
that referenced
this pull request
May 5, 2026
…y functions (PR #341) Agent-Logs-Url: https://github.com/tidyomics/tidybulk/sessions/6629bc9d-eb57-4447-8225-94694486a312 Co-authored-by: stemangiola <7232890+stemangiola@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add identify_abundant_per_category and keep_abundant_per_category as an alternative implementation of identify_abundant and keep_abundant. This alternative implementation does not use filterByExpr() and behaves closer to what is described in the helper documents.
On a minor side, I add verbal messages on overriding behaviour of CPM to counts, and some guards on parameter validity.