Skip to content

feat(android): update cpp files for unpachted v8 versions#14413

Draft
m1ga wants to merge 1 commit intomainfrom
v8fixes
Draft

feat(android): update cpp files for unpachted v8 versions#14413
m1ga wants to merge 1 commit intomainfrom
v8fixes

Conversation

@m1ga
Copy link
Copy Markdown
Contributor

@m1ga m1ga commented Mar 28, 2026

just a draft PR for an unpatched v8 version: tidev/v8_titanium#57

Changes also include:

  1. V8Runtime.cpp:80-110 - Fixed O(n²) string concatenation in krollLog:
  • Uses std::string for accumulation (O(n))
  • Only converts to V8 strings at the end for logging
  1. V8Util.cpp - Added JSON.stringify caching:
  • Added static jsonStringifyFunction Persistent to cache the function
  • First call looks up JSON.stringify and caches it
  • Subsequent calls use the cached function directly
  • Updated dispose() to clean up the cached function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant