feat(android): reduce TableView/ListView layout#14319
Draft
Conversation
…ndroidFlatLists
Contributor
|
Contributor
Author
|
the idea was that this setting can be used when you know you don't use the settings so you have the smallest layout. But yes, we could remove the header-/footerTitle as a simple label will be better already. Since we have it in the docs as the examples we should remap the properties for a normal label in the main content. That way we can remove the two fields from the layout |
Collaborator
|
Can't it be added dynamically using code instead of pre-adding them via layout? Should be good to refactor (detect properties that were set, add if relevant properties for the views) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimenting with TableView/ListView layouts to reduce the complexity of the layout. Many people don't use header/footer views or the left/right image but only add views in the rows. Still the layout will have all these elements in it.
This PR will add a property
flatLayout:trueto the TableView and it will load a different layout XML that only uses the content section.current layout for one TableViewRow (13.0.0.GA):
After this PR:
Same for the listView:
Demo: