fix(ios): fixed ref counting of navTintColor#14297
Open
hbugdoll wants to merge 1 commit intotidev:mainfrom
Open
fix(ios): fixed ref counting of navTintColor#14297hbugdoll wants to merge 1 commit intotidev:mainfrom
hbugdoll wants to merge 1 commit intotidev:mainfrom
Conversation
Contributor
|
Functional test: I've tested both examples and I don't see any crash with this PR 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14211.
Description:
navTintColorfor a tab group, not for windownewColorwas set to a new object and was unretained when later releasednewTintColorinside the block to holdnewColornewColorifcontroller == nilSuccessfully tested with both code examples #14211 (comment) and #13917 (comment) in simulator.