Skip to content

WEB-4654 - Tags & Sites - #1985

Open
henry-tp wants to merge 32 commits into
WEB-4654-filter-barfrom
WEB-4654-tags
Open

WEB-4654 - Tags & Sites#1985
henry-tp wants to merge 32 commits into
WEB-4654-filter-barfrom
WEB-4654-tags

Conversation

@henry-tp

@henry-tp henry-tp commented Jul 14, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (4)
  • master
  • main
  • develop
  • release.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3bb7722f-d853-4fa2-bb41-c6c7375fafa0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch WEB-4654-tags

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

henry-tp added 24 commits July 14, 2026 00:08
@henry-tp
WEB-4654 remove prefixPopHealthMetric from abstracted components
a8f3ff7
@henry-tp
Merge branch 'WEB-4654-filter-bar' into WEB-4654-tags
ae860b6
@henry-tp
WEB-4654 remove unused popup state hooks
be84197
@henry-tp
WEB-4654 restyle tags and sites dropdown to new UI design
dcb6cd4
@henry-tp
WEB-4654 fix margins
1601f39
@henry-tp
WEB-4654 add safety in case of missing label
43d0e72
@henry-tp
Merge branch 'WEB-4654-filter-bar' into WEB-4654-tags
330081c
@henry-tp
Merge branch 'WEB-4654-filter-bar' into WEB-4654-tags
e4f1c9f
@henry-tp
WEB-4654 change directory for FilterBySites & FilterByTags
26b52b4
@henry-tp
WEB-4654 change empty tag/site copy per new requirements
44f608d
@henry-tp
WEB-4654 fix copy per new requirements
f904994
@henry-tp
WEB-4654 use circle-add icon
2f75d56
@henry-tp
WEB-4654 clear unneeded props
f3407da
@henry-tp
WEB-4654 update trackMetric fn calls
2db2bfe
@henry-tp
WEB-4654 use dedicated file for useClinicMetricsPageName
c01fd80
@henry-tp
WEB-4654 add tests for adapter components
bde85e8
@henry-tp
WEB-4654 add tests for TagFilterDropdown
c13309c
@henry-tp
WEB-4654 re-add in top-level integration test for filtering
4d585cb
@henry-tp
Merge branch 'WEB-4654-filter-bar' into WEB-4654-tags
8bcd604
@henry-tp
WEB-4654 optimize tag icon
db493a6
@henry-tp
WEB-4654 use MemoryRouter instead of mocking out location hook
dfecb45
@henry-tp
WEB-4654 autofocus search on mount
d6f0e85
@henry-tp
Merge branch 'WEB-4654-filter-bar' into WEB-4654-tags
9424e83
@henry-tp
WEB-4654 remove unused var
1d01fc2
@henry-tp
henry-tp requested a review from clintonium-119 July 21, 2026 21:35
henry-tp
henry-tp commented Jul 21, 2026
View reviewed changes
Comment thread app/pages/clinicworkspace/clinicPatientsFilters/FilterBySites.js
import SiteFilterDropdown from '../components/SiteFilterDropdown';
import useIsClinicAdmin from '../useIsClinicAdmin';
import useClinicMetricsPageName from '../useClinicMetricsPageName';

@henry-tp henry-tp Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another adapter component, mapping the state setters of ClinicPatients to the API of the Dropdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clintonium-119 clintonium-119 Awaiting requested review from clintonium-119

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@henry-tp