WEB-4611 - Round CGM use before display - #1961
Open
henry-tp wants to merge 1 commit into
Open
Conversation
henry-tp
changed the title
henry-tp
added
Needs Release Target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WEB-4611
The issue is that the minimum threshold of
70%is being compared to the unrounded value (e.g.69.6734%) instead of the rounded value. The fix is that69.xyz%should be treated like70%and we should be using the rounded value for all intents and purposes.The reason we don't need to do it for the rest of the numbers in the tooltip is because the adjustment of the stats is handled by a call within
<BgSummaryCell />toreconcileTIRPercentages()