Skip to content

Add Milvus GetFlushState compatibility #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
g4197 merged 1 commit into from
Jun 24, 2026
Merged

Add Milvus GetFlushState compatibility #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/server/milvus_server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,28 @@ Status MilvusServiceImpl::GetLoadState(grpc::ServerContext *, const pb_milvus::G

Status MilvusServiceImpl::Flush(grpc::ServerContext *, const pb_milvus::FlushRequest *req,
pb_milvus::FlushResponse *resp) {
for (const auto &name : req->collection_names()) store_->flush(name);
for (const auto &name : req->collection_names()) {
store_->flush(name);
// Flush is synchronous; these fields only exist so pymilvus can poll
// GetFlushState without failing.
(*resp->mutable_coll_segids())[name];
(*resp->mutable_flush_coll_segids())[name];
(*resp->mutable_coll_flush_ts())[name] = 1;
}
*resp->mutable_status() = ok_status();
return Status::OK;
}

Status MilvusServiceImpl::GetFlushState(grpc::ServerContext *, const pb_milvus::GetFlushStateRequest *req,
pb_milvus::GetFlushStateResponse *resp) {
if (!req->collection_name().empty() && !store_->has_collection(req->collection_name())) {
*resp->mutable_status() = err_status("collection not found");
return Status::OK;
}
*resp->mutable_status() = ok_status();
// Flush completes before the RPC returns, so any follow-up state check is
// immediately satisfied.
resp->set_flushed(true);
return Status::OK;
}

Expand Down
2 changes: 2 additions & 0 deletions src/server/milvus_server.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ class MilvusServiceImpl final : public pb_milvus::MilvusService::Service {
pb_milvus::GetLoadingProgressResponse *resp) override;
grpc::Status Flush(grpc::ServerContext *ctx, const pb_milvus::FlushRequest *req,
pb_milvus::FlushResponse *resp) override;
grpc::Status GetFlushState(grpc::ServerContext *ctx, const pb_milvus::GetFlushStateRequest *req,
pb_milvus::GetFlushStateResponse *resp) override;

// Partitions. PipeANN has no partition concept (partition-scoped filtering is
// handled through the attribute filter path), so these are compatibility
Expand Down
Loading