Repository navigation
v1.34.0 - #616
Merged
Merged
v1.34.0#616
Conversation
Back to development
Adds an option union-decode-relaxed which enables a flexible union decoding mode that permits unknown values and returns an empty union struct in such cases. Context Currently, thriftrw-go generated code deserialize unknown Enum values correctly by preserving them and passing them to the client for appropriate handling. However, for Unions, thriftrw-go generated code fails to deserialize unknown cases gracefully, leading to runtime errors and service outages when new fields are introduced on the server side. This change introduces an opt-in mechanism in thriftrw-go generated code to allow unknown field in Union deserialization. It ensures backward compatibility in evolving schemas, complies with the Robustness Principle, and defers handling decisions to the caller.
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 68.01% 69.82% +1.80%
==========================================
Files 142 142
Lines 23878 28159 +4281
==========================================
+ Hits 16241 19661 +3420
- Misses 4577 5360 +783
- Partials 3060 3138 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sywhang
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
mode that permits unknown values and returns an empty union struct in such cases.