Fix: replace mysqljs with mysql2#7590
Merged
Conversation
Migrates from mysqljs to mysql2 to support MySQL 8.4+.
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.16.2 to 1.16.5. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.16.2...v1.16.5) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.5 to 3.2.8. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.5...v3.2.8) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 48.2.4 to 48.2.5. - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc) - [Commits](gajus/eslint-plugin-jsdoc@v48.2.4...v48.2.5) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sinon](https://github.com/sinonjs/sinon) from 17.0.2 to 18.0.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](sinonjs/sinon@v17.0.2...v18.0.0) --- updated-dependencies: - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Updates the docker compose file to use mysql 8.4.
jmcameron
approved these changes
May 23, 2024
Collaborator
jmcameron
left a comment
jmcameron
left a comment
There was a problem hiding this comment.
The code changes look very reasonable. And I feel that is an issue that needs to be addressed soon, so I'm happy to accept this PR.
I tested this branch on my local test setup and it works without any issues. All regular and end-to-end tests pass.
I did not test the parts of this related to running with Docker compose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
mysqlwithmysql2. Learn more about some of the benefits of usingmysql2here.The reason I am making this change is because MySQL 8.4 completely removed compatibility for the default authentication method we were using previously (mysql_native_password). If you tried to start the server with MySQL 8.4, you would receive this warning:
The
mysqlnpm package is de facto deprecated in lieu of themysql2npm package. There has been an outstanding pull request to add in the new authentication methods, but it doesn't look like this has any chance of being merged anytime soon.Note that, for docker, the plugin has been removed, but a new flag has been added
--mysql-native-password=ONto enable the mysql-native password authentication. We'll likely need to switch off this in a future version to their SHA2 caching plugin. However, I'm not sure what that would involve at this point. Using this flag is a stopgap while we figure that out.