Skip to content

Fixes #39268 - Fix dependency issues for foreman_templates #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamruzicka merged 2 commits into from
Apr 28, 2026
+3 −18
Merged

Fixes #39268 - Fix dependency issues for foreman_templates #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ed2f51
Fixes #39268 - Fix dependency issues for foreman_templates
ofedoren Apr 28, 2026
d4ec19e
Refs #39268 - Drop rdoc dependency
ofedoren Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
source "http://rubygems.org"

gemspec

gem "rake"
gem "theforeman-rubocop", '~> 0.1.2', require: false, groups: %i[development rubocop]
15 changes: 0 additions & 15 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,6 @@ begin
rescue LoadError
puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
end
begin
require 'rdoc/task'
rescue LoadError
require 'rdoc/rdoc'
require 'rake/rdoctask'
RDoc::Task = Rake::RDocTask
end

RDoc::Task.new(:rdoc) do |rdoc|
rdoc.rdoc_dir = 'rdoc'
rdoc.title = 'ForemanTemplates'
rdoc.options << '--line-numbers'
rdoc.rdoc_files.include('README.md')
rdoc.rdoc_files.include('lib/**/*.rb')
end

Bundler::GemHelper.install_tasks
task :default => :test
3 changes: 0 additions & 3 deletions foreman_templates.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,4 @@ Gem::Specification.new do |s|

s.add_dependency "diffy"
s.add_dependency "git"
s.add_development_dependency "rake"
s.add_development_dependency "rdoc"

@ofedoren ofedoren Apr 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just due to the recent trend, I've removed rdoc in a separate commit.

s.add_development_dependency "theforeman-rubocop"
end
Loading