Skip to content

Fixes #39764 - Delete deprecated components in common/xyz - #11244

Merged
adamruzicka merged 1 commit into
theforeman:developfrom
Lukshio:deleteCommon
Oct 8, 2026
Merged

adamruzicka merged 1 commit into
theforeman:developfrom
Lukshio:deleteCommon

Conversation

@Lukshio

@Lukshio Lukshio commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Removing deprecated components and replaces usage of MessageBox.

@kmalyjur kmalyjur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import { MessageBox } from 'foremanReact/components/common/MessageBox';
mentiones "MessageBox"

<EmptyState
header={__('Invalid Status')}
variant="sm"
icon={ExclamationCircleIcon}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon is missing

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

@kmalyjur kmalyjur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it can be merged

@Lukshio

Lukshio commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Commits squashed, blocker merged

@Lukshio

Lukshio commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Packit tested

@adamruzicka adamruzicka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pro-forma ACK, the real ACK(s) are in the comments.

@adamruzicka
adamruzicka merged commit a327bb5 into theforeman:develop Oct 8, 2026
41 checks passed
@adamruzicka

Copy link
Copy Markdown
Contributor

Thank you @Lukshio & reviewers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants