Skip to content

redo lookup#371

Merged
rafzip merged 2 commits into
mainfrom
lookup
Jun 26, 2026
Merged

redo lookup#371
rafzip merged 2 commits into
mainfrom
lookup

Conversation

@LucienMorey

@LucienMorey LucienMorey commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

need TOF calcs from @rafzip

@greptile-apps

greptile-apps Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR extends the ballistics lookup tables from 6 to 9 distance entries (adding 4.5, 5.0, and 5.5 m) with new speed values, and lowers HOPPER_SURFACE_SPEED from 12 to 10 m/s. The PR description acknowledges that time-of-flight values for the three new distances are still pending.

  • The three new SPEED_LOOKUP entries and the HOPPER_SURFACE_SPEED change are otherwise well-formed.
  • TIME_LOOKUP uses bare TODO identifiers for the three new entries, which are not defined Python names and will raise a NameError on module import, making the entire robot code unable to load components/ballistics.py.

Confidence Score: 1/5

Not safe to merge — the module cannot be imported in its current state, which would break all robot code that depends on ballistics.

The three bare TODO identifiers in TIME_LOOKUP will cause a NameError the moment Python tries to evaluate the array literal, preventing components/ballistics.py from loading at all. No part of the robot that imports this module — directly or transitively — will function until real TOF values replace the placeholders.

components/ballistics.py — TIME_LOOKUP line 13 must have real numeric values for the 4.5, 5.0, and 5.5 m entries before this can be merged.

Important Files Changed

Filename Overview
components/ballistics.py Lookup tables extended to 9 entries (up to 5.5 m) and HOPPER_SURFACE_SPEED lowered from 12 to 10, but TIME_LOOKUP contains three bare TODO identifiers that cause a NameError on import.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Module Import] --> B[Evaluate DISTANCE_LOOKUP\n9 entries: 1.75 – 5.5 m]
    A --> C[Evaluate SPEED_LOOKUP\n9 entries: 63 – 106 rps]
    A --> D[Evaluate TIME_LOOKUP\n6 real values + 3 × TODO]
    D --> E[NameError: 'TODO' is not defined]
    E --> F[Module fails to import]
    B --> G{All arrays valid?}
    C --> G
    G -- No --> F
    G -- Yes --> H[Build LookupTable & TABLE\nBallisticsSolver available]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Module Import] --> B[Evaluate DISTANCE_LOOKUP\n9 entries: 1.75 – 5.5 m]
    A --> C[Evaluate SPEED_LOOKUP\n9 entries: 63 – 106 rps]
    A --> D[Evaluate TIME_LOOKUP\n6 real values + 3 × TODO]
    D --> E[NameError: 'TODO' is not defined]
    E --> F[Module fails to import]
    B --> G{All arrays valid?}
    C --> G
    G -- No --> F
    G -- Yes --> H[Build LookupTable & TABLE\nBallisticsSolver available]
Loading

Reviews (1): Last reviewed commit: "redo lookup" | Re-trigger Greptile

@Alexander-Mironenko Alexander-Mironenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty now tell me where the bathroom is

@rafzip rafzip merged commit 9a248bf into main Jun 26, 2026
7 checks passed
@rafzip rafzip deleted the lookup branch June 26, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants