TypeScript 7 - #1167
Open
TheArcaneBrony wants to merge 2 commits into
Open
Conversation
|
|
GHCR image refs for this PR:
This comment is generated from PR metadata only. It does not checkout or run PR code and is generated in a static manner |
Contributor
Author
|
(builds work locally, fwiw, justnot linting, not sure why CI broke there) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the project compile with typescript 7
Followed backwards compat guidelines (for eg. typescript-eslint) documented at https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0, except kept it at 5.9.3 as used previously in the project.
Though... eslint doesnt appear to work...?
(can confirm that dir doesnt exist, even after wiping node_modules and ~/.npm...)
Signed-off-by: Emma [it/its] @ Rory&