Support for nodemcu32_uart - #97
Draft
jwidess wants to merge 7 commits into
Draft
Conversation
Added env for nodemcu32 UART
Author
|
Reviewing this again, it looks like using the Due to lines 37-39 in main.cpp and the #ifndef. I'll review this further and see how I was successfully building this for my nodemcu32 using only UART... |
Removed leading underscores(_) from CAN_TX_PIN/CAN_RX_PIN in platformio.ini (now 26, 27) and simplified CanDevice.h GPIO macro to use these. Can't see a reason why the ESP32S3 had different `#ifndef`
Removed ` -D CANBUS_ENABLED` from UART variant.
Configurable VESC_UART_PORT macro (default 2) in config.h for the HardwareSerial in main.cpp instead of a hardcoded port. This allows for boards like the ESP32-C3. Add preprocessor checks in main.cpp to enforce that CANBUS_ENABLED and CANBUS_ONLY are either both defined (CAN mode) or both undefined (UART mode). I'd like to eventually see if we can allow for just CANBUS_ENABLED to support a dual UART and CANBUS_ENABLED setup.
Added esp32c3_devkitm_1 support, both CAN and UART variants.
Updated GitHub Actions workflow to build and publish environments: esp32c3_devkitm_1, esp32c3_devkitm_1_uart, and nodemcu-32s_uart
Author
|
Going to rework this PR to incorporate my new changes and supported boards. Still working on getting the ESP32-C3 working, currently running into a panic on the BleServer... |
jwidess
marked this pull request as draft
March 24, 2026 04:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added env for nodemcu32 UART to simplify env setup, #61