wheel maxBrightness fix in Ws28xxController.cpp - #100
Open
jwidess wants to merge 2 commits into
Open
Conversation
Rainbow preset didn't have maxBrightness factor applied, fixed. AI Summary: Refactor Ws28xxController::wheel(byte) to compute red/green/blue into variables rather than returning early, then scale each channel by a constrained maxBrightness (0..255) using 16-bit intermediate math and return the adjusted Color. This ensures the generated wheel colors respect the controller's global brightness setting and avoids duplicated return paths.
Bumped SOFTWARE_VERSION_PATCH from 7 to 8 in config.h for this wheel fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rainbow preset didn't have maxBrightness factor applied, fixed. The main change is to compute the RGB values and then scale them according to the
maxBrightnesssetting before returning the color.