Skip to content

feat: add SDA protocol support (getSdaProtocol) #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathunne merged 7 commits into from
Jul 29, 2026
Merged

feat: add SDA protocol support (getSdaProtocol) #73

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b48fdaf
feat: add SDA protocol support (getSdaProtocol)
AlonzoRicardo Jun 24, 2026
e2f47d4
chore: depend on wdk-wallet@^1.0.0-beta.15 (SDA release) and regenera…
AlonzoRicardo Jun 24, 2026
61cd087
test: cover the getSdaProtocol wiring (registration, dispatch, unsupp…
AlonzoRicardo Jul 22, 2026
8aa2ed4
test: fold getSdaProtocol coverage into wdk.test.js sibling blocks
AlonzoRicardo Jul 27, 2026
9b022b3
fix(policy): govern SDA methods and fix getSdaProtocol crash on gover…
AlonzoRicardo Jul 27, 2026
dd52dd7
fix(types): drop ad-hoc *ProtocolCtor typedefs from registerProtocol …
AlonzoRicardo Jul 28, 2026
634240e
Improve readability.
Davi0kProgramsThings Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions src/wallet-account-with-protocols.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,11 @@
import { IWalletAccount, NotImplementedError } from '@tetherto/wdk-wallet'

/** @typedef {import('@tetherto/wdk-wallet/protocols').ISwapProtocol} ISwapProtocol */
/** @typedef {typeof import('@tetherto/wdk-wallet/protocols').SwapProtocol} SwapProtocolCtor */

/** @typedef {import('@tetherto/wdk-wallet/protocols').IBridgeProtocol} IBridgeProtocol */
/** @typedef {typeof import('@tetherto/wdk-wallet/protocols').BridgeProtocol} BridgeProtocolCtor */

/** @typedef {import('@tetherto/wdk-wallet/protocols').ILendingProtocol} ILendingProtocol */
/** @typedef {typeof import('@tetherto/wdk-wallet/protocols').LendingProtocol} LendingProtocolCtor */

/** @typedef {import('@tetherto/wdk-wallet/protocols').IFiatProtocol} IFiatProtocol */
/** @typedef {typeof import('@tetherto/wdk-wallet/protocols').FiatProtocol} FiatProtocolCtor */

/** @typedef {import('@tetherto/wdk-wallet/protocols').ISwidgeProtocol} ISwidgeProtocol */
/** @typedef {typeof import('@tetherto/wdk-wallet/protocols').SwidgeProtocol} SwidgeProtocolCtor */

/** @typedef {import('@tetherto/wdk-wallet/protocols').ISdaProtocol} ISdaProtocol */
/** @typedef {typeof import('@tetherto/wdk-wallet/protocols').SdaProtocol} SdaProtocolCtor */

/**
* Interface for wallet accounts that also expose the WDK's protocol-getter
Expand All @@ -52,7 +41,7 @@ export class IWalletAccountWithProtocols extends IWalletAccount {
* The label must be unique in the scope of the account and the type of protocol (i.e., there can’t be two protocols of the same
* type bound to the same account with the same label).
*
* @template {SwapProtocolCtor | BridgeProtocolCtor | LendingProtocolCtor | FiatProtocolCtor | SwidgeProtocolCtor | SdaProtocolCtor} P
* @template {typeof import('@tetherto/wdk-wallet/protocols').SwapProtocol | typeof import('@tetherto/wdk-wallet/protocols').BridgeProtocol | typeof import('@tetherto/wdk-wallet/protocols').LendingProtocol | typeof import('@tetherto/wdk-wallet/protocols').FiatProtocol | typeof import('@tetherto/wdk-wallet/protocols').SwidgeProtocol | typeof import('@tetherto/wdk-wallet/protocols').SdaProtocol} P
Comment thread
Davi0kProgramsThings marked this conversation as resolved.
Outdated
* @param {string} label - The label.
* @param {P} Protocol - The protocol class.
* @param {ConstructorParameters<P>[1]} config - The protocol configuration.
Expand Down
16 changes: 2 additions & 14 deletions types/src/wallet-account-with-protocols.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
/** @typedef {import('@tetherto/wdk-wallet/protocols').ISwapProtocol} ISwapProtocol */
/** @typedef {typeof import('@tetherto/wdk-wallet/protocols').SwapProtocol} SwapProtocolCtor */
/** @typedef {import('@tetherto/wdk-wallet/protocols').IBridgeProtocol} IBridgeProtocol */
/** @typedef {typeof import('@tetherto/wdk-wallet/protocols').BridgeProtocol} BridgeProtocolCtor */
/** @typedef {import('@tetherto/wdk-wallet/protocols').ILendingProtocol} ILendingProtocol */
/** @typedef {typeof import('@tetherto/wdk-wallet/protocols').LendingProtocol} LendingProtocolCtor */
/** @typedef {import('@tetherto/wdk-wallet/protocols').IFiatProtocol} IFiatProtocol */
/** @typedef {typeof import('@tetherto/wdk-wallet/protocols').FiatProtocol} FiatProtocolCtor */
/** @typedef {import('@tetherto/wdk-wallet/protocols').ISwidgeProtocol} ISwidgeProtocol */
/** @typedef {typeof import('@tetherto/wdk-wallet/protocols').SwidgeProtocol} SwidgeProtocolCtor */
/** @typedef {import('@tetherto/wdk-wallet/protocols').ISdaProtocol} ISdaProtocol */
/** @typedef {typeof import('@tetherto/wdk-wallet/protocols').SdaProtocol} SdaProtocolCtor */
/**
* Interface for wallet accounts that also expose the WDK's protocol-getter
* helpers (`registerProtocol`, `getSwapProtocol`, `getBridgeProtocol`,
Expand All @@ -28,13 +22,13 @@ export class IWalletAccountWithProtocols {
* The label must be unique in the scope of the account and the type of protocol (i.e., there can’t be two protocols of the same
* type bound to the same account with the same label).
*
* @template {SwapProtocolCtor | BridgeProtocolCtor | LendingProtocolCtor | FiatProtocolCtor | SwidgeProtocolCtor | SdaProtocolCtor} P
* @template {typeof import('@tetherto/wdk-wallet/protocols').SwapProtocol | typeof import('@tetherto/wdk-wallet/protocols').BridgeProtocol | typeof import('@tetherto/wdk-wallet/protocols').LendingProtocol | typeof import('@tetherto/wdk-wallet/protocols').FiatProtocol | typeof import('@tetherto/wdk-wallet/protocols').SwidgeProtocol | typeof import('@tetherto/wdk-wallet/protocols').SdaProtocol} P
* @param {string} label - The label.
* @param {P} Protocol - The protocol class.
* @param {ConstructorParameters<P>[1]} config - The protocol configuration.
* @returns {IWalletAccountWithProtocols} The account.
*/
registerProtocol<P extends SwapProtocolCtor | BridgeProtocolCtor | LendingProtocolCtor | FiatProtocolCtor | SwidgeProtocolCtor | SdaProtocolCtor>(label: string, Protocol: P, config: ConstructorParameters<P>[1]): IWalletAccountWithProtocols;
registerProtocol<P extends typeof import("@tetherto/wdk-wallet/protocols").SwapProtocol | typeof import("@tetherto/wdk-wallet/protocols").BridgeProtocol | typeof import("@tetherto/wdk-wallet/protocols").LendingProtocol | typeof import("@tetherto/wdk-wallet/protocols").FiatProtocol | typeof import("@tetherto/wdk-wallet/protocols").SwidgeProtocol | typeof import("@tetherto/wdk-wallet/protocols").SdaProtocol>(label: string, Protocol: P, config: ConstructorParameters<P>[1]): IWalletAccountWithProtocols;
/**
* Returns the swap protocol with the given label.
*
Expand Down Expand Up @@ -85,14 +79,8 @@ export class IWalletAccountWithProtocols {
getSdaProtocol(label: string): ISdaProtocol;
}
export type ISwapProtocol = import("@tetherto/wdk-wallet/protocols").ISwapProtocol;
export type SwapProtocolCtor = typeof import("@tetherto/wdk-wallet/protocols").SwapProtocol;
export type IBridgeProtocol = import("@tetherto/wdk-wallet/protocols").IBridgeProtocol;
export type BridgeProtocolCtor = typeof import("@tetherto/wdk-wallet/protocols").BridgeProtocol;
export type ILendingProtocol = import("@tetherto/wdk-wallet/protocols").ILendingProtocol;
export type LendingProtocolCtor = typeof import("@tetherto/wdk-wallet/protocols").LendingProtocol;
export type IFiatProtocol = import("@tetherto/wdk-wallet/protocols").IFiatProtocol;
export type FiatProtocolCtor = typeof import("@tetherto/wdk-wallet/protocols").FiatProtocol;
export type ISwidgeProtocol = import("@tetherto/wdk-wallet/protocols").ISwidgeProtocol;
export type SwidgeProtocolCtor = typeof import("@tetherto/wdk-wallet/protocols").SwidgeProtocol;
export type ISdaProtocol = import("@tetherto/wdk-wallet/protocols").ISdaProtocol;
export type SdaProtocolCtor = typeof import("@tetherto/wdk-wallet/protocols").SdaProtocol;