fix[notask]: drain in-flight blob blocks before cleanup - #3582
Merged
Conversation
Contributor
Review StatusCurrent Status: ✅ APPROVED |
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
Victor-Rodzko
approved these changes
Jul 31, 2026
opaninakuffo
approved these changes
Jul 31, 2026
opaninakuffo
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cancelled registry downloads can still persist Hypercore blocks after the range request is destroyed. Responses already in flight may arrive between
destroy()andclear(), so the cache continues growing across distinct cancellations.How does it solve it?
inflight/dataProcessingcounters and still clears (best-effort).core.verifysodataProcessingstays nonzero past the drain deadline, plus a focused unit coverage of the timeout log payload.Breaking changes
None.
Replaces #3496 (same change, opened from an upstream branch instead of a fork).