Added logging, comments and improved error messaging + fixed bug in parallelization test suite

[selenareneephillips]

Changes:

1. Implemented logging information for the parallelization test suite so debugging intermittent errors on Team City will be easier
2. Added source code comments to clarify how the verification of parallelization is done for blocks of methods expected to be executing in parallel.
3. Improved error messages for failures in the verification of parallelization so that they are more helpful in pinpointing the reasons for failures
4. Make the execution state tracker final and changed the reset method to remove logs rather than reassign the variable with a new list. This was because Intellij warned me that a non-final variable for holding the event logs could cause problems with threads getting a lock on it.
5. Fixed a bug in the calculation of the expected size of the last block of methods to execute in parallel when processing event logs for test methods which do not use data providers without factories.

[selenareneephillips]

One of the test runs stalled out, but in some other test suite, so it seems unrelated to the parallelization test suite. I can't seem to find a re-run button, so had to close and reopen the pull request to force a rebuild to occur.

[selenareneephillips]

The second run had another failure, but it's one I have seen intermittently before -- the concurrent modification test.

BTW, this test is failing on my local env:

Gradle Test Executor 2 STANDARD_OUT
Failures in :TestNG, :Regression2
test.issue565.Issue565Test.ThereShouldNotBeDeadlockWhenGroupByInstanceAndGroupDependencyUsed()
StackTrace:
java.lang.AssertionError: expected [82] but found [24]
at test.issue565.Issue565Test.ThereShouldNotBeDeadlockWhenGroupByInstanceAndGroupDependencyUsed(Issue565Test.java:39)
at com.sun.proxy.$Proxy2.stop(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
... Removed 49 stack frames

[selenareneephillips]

I have been searching for hours for information about how to get gradle to display logging statements sent to the console from java.util.logging. Does anyone know how to do that? I really don't want to write a bunch of System.out.println statements replace the user of a real logger.

[krmahadevan]

@selenareneephillips - Can you please check if this helps ?

[selenareneephillips]

@krmahadevan I tried out those suggestions -- find the parent ConsoleHandler, using a customer logging.properties file, etc. Still, when I run 'gradle test' I still see no output from my loggers. When I run the tests in IntelliJ, I get output from my loggers. Running the command line, I get nothing from them.

[juherr]

LGTM 👍
Ping @cbeust

[juherr]

@selenareneephillips Only the committers of the repository are able to rerun build.

ThereShouldNotBeDeadlockWhenGroupByInstanceAndGroupDependencyUsed is another random test I introduced with #1477 and #1478 should help but I saw random results with it too. :/

About the gradle/travisci issue, I agree and it is a real pain when a test is failing. I am opening an issue because we should improve it