Skip to content

build(deps): bump floki & gettext, remove override on ranch, require elixir 1.19#5142

Merged
JakobLichterfeld merged 4 commits into
mainfrom
swiffer/deps-2
Feb 14, 2026
Merged

build(deps): bump floki & gettext, remove override on ranch, require elixir 1.19#5142
JakobLichterfeld merged 4 commits into
mainfrom
swiffer/deps-2

Conversation

@swiffer
Copy link
Copy Markdown
Collaborator

@swiffer swiffer commented Feb 14, 2026

bumped

require Elixir 1.19 in mix

  • @JakobLichterfeld, this currently breaks ensure_linting workflow (Elixir 1.18.4 is used there) - do you know why?

remove override from ranch, no longer needed

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 14, 2026

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 919a8ce
🔍 Latest deploy log https://app.netlify.com/projects/teslamate/deploys/69908e18950cfb0008008d58
😎 Deploy Preview https://deploy-preview-5142--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@swiffer swiffer changed the title deps: bump floki & gettext, remove override on ranch, require elixir 1.19 build(deps): bump floki & gettext, remove override on ranch, require elixir 1.19 Feb 14, 2026
@swiffer swiffer self-assigned this Feb 14, 2026
@swiffer swiffer added dependencies Pull requests that update a dependency file area:teslamate Related to TeslaMate core labels Feb 14, 2026
@JakobLichterfeld
Copy link
Copy Markdown
Member

JakobLichterfeld commented Feb 14, 2026

  • @JakobLichterfeld, this currently breaks ensure_linting workflow (Elixir 1.18.4 is used there) - do you know why?

Damm, looked into it as I couldn't explain. It seems like treefmt-nix use package = "elixir"; https://github.com/numtide/treefmt-nix/blob/337a4fe074be1042a35086f15481d763b8ddc0e7/programs/mix-format.nix#L8

which resolves to 1.18.4. We use for your package pkgs.beam.packages.erlang_26.elixir_1_19

elixir = pkgs.beam.packages.erlang_26.elixir_1_19;

I will try to override treefmt-nix package

@swiffer
Copy link
Copy Markdown
Collaborator Author

swiffer commented Feb 14, 2026

According to the docs it looks like the program can be overwritten?

https://github.com/numtide/treefmt-nix?tab=readme-ov-file#nix-classic-without-flakes

@JakobLichterfeld
Copy link
Copy Markdown
Member

JakobLichterfeld commented Feb 14, 2026

According to the docs it looks like the program can be overwritten?

Yeah, that's what I mean with:

I will try to override treefmt-nix package

I was a bit confused at first, but after some time off, I figured it out.

Copy link
Copy Markdown
Member

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@JakobLichterfeld JakobLichterfeld merged commit 3cf44aa into main Feb 14, 2026
25 checks passed
@JakobLichterfeld JakobLichterfeld deleted the swiffer/deps-2 branch February 14, 2026 15:35
@sdwalker
Copy link
Copy Markdown
Contributor

Backed down the elixir to 1.18 as Debian doesn't have 1.19 either

@swiffer
Copy link
Copy Markdown
Collaborator Author

swiffer commented Feb 15, 2026

Haven't really thought about the unsupported install methods.

Looks like FreeBSD and Debian have only 1.17 / 1.18 available.

Enforcing 1.19 is now effectively blocking install.

We could relax the requirement to e.g. 1.17 - not sure if any other version bumps are causing issues.

@brianmay
Copy link
Copy Markdown
Collaborator

What would be idea is if we can run the tests against both 1.18 and 1.19 then.

(unless there is any good reason for 1.17 over 1.18 that I missed)

@swiffer
Copy link
Copy Markdown
Collaborator Author

swiffer commented Feb 15, 2026

FreeBSD has 1.17 only.

Running the Testsuite with a Matrix (Elixir 1.17 / Postgres 16.7 || Elixir 1.19 / Postgres 18) should be fine.

Will relax the Elixir constraint later today and open a new issue to propose some changes to the current CI/CD Flow.

@swiffer
Copy link
Copy Markdown
Collaborator Author

swiffer commented Feb 15, 2026

see #5145

@JakobLichterfeld JakobLichterfeld added this to the v3.0.0 milestone May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:teslamate Related to TeslaMate core dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants