Use shader() attribute with size/align as arguments#100
Merged
Conversation
Aceeri
changed the title
shader() attribute with size/align instead of itshader() attribute with size/align as arguments
Contributor
Author
|
A bit unsure how to fix the CI, llvm-cov is failing and I can't tell which part of my changes caused this. Would appreciate some help there |
Owner
|
Line coverage is under 80% now, on main it's ~83%. Looking at the changes I'm not sure why though. |
Owner
|
Sorry I should have reviewed this earlier, would you be able to rebase it? |
Contributor
Author
|
Ya I'll take a look |
Contributor
Author
|
@teoxoy should be good now |
teoxoy
reviewed
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same goal as #99
Just to change it to
#[shader(align, size(..))]instead of#[shader_align]/#[size(..)]