DT-3655 - add external payload count and size to workflow details#3276
Open
rossedfort wants to merge 7 commits intomainfrom
Open
DT-3655 - add external payload count and size to workflow details#3276rossedfort wants to merge 7 commits intomainfrom
rossedfort wants to merge 7 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| @@ -145,6 +145,10 @@ export const toWorkflowExecution = ( | |||
| const priority = response.workflowExecutionInfo?.priority; | |||
Contributor
There was a problem hiding this comment.
⚠️ 'response' is possibly 'undefined'.
| historySizeBytes, | ||
| externalPayloadCount, | ||
| externalPayloadSizeBytes, | ||
| searchAttributes, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'IMemo | undefined' is not assignable to type 'IMemo'.
| externalPayloadCount, | ||
| externalPayloadSizeBytes, | ||
| searchAttributes, | ||
| memo, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'IWorkflowExecution | null | undefined' is not assignable to type 'IWorkflowExecution | undefined'.
Contributor
|
|
Screengrabs LGTM! |
|
hey Ross - I had updated the styling in this detail list for the labels to be body medium secondary text to provide some visual distinction between the key and the value. This got the OK from the design team. I'd like to see that updated here. Additionally, all numerical text (so, timestamps, time durations, size values, etc.) should be in our monotype font. Can we update that too? Lastly, can you add in the Docs link next to the SDK label? Idk where my annotation went in figma - i swear i put it in there, but it should go to https://docs.temporal.io/develop/{sdk-type} e.g. https://docs.temporal.io/develop/go/ or https://docs.temporal.io/develop/python/. I had it with the external link icon but I think it should actually be the Thanks! |
…ils header - add class prop to DetailListTextValue and DetailListValue to pass through font-mono - make DetailListLabel text-secondary - add link to SDK developer guides next to SDK logo - replace SDK logos with our own colorblock versions
| }: Props = $props(); | ||
| const { copy, copied } = copyToClipboard(); | ||
|
|
||
| const handleCopy = (e: Event) => { |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
| >{translate('workflows.external-payload-size')}</DetailListLabel | ||
| > | ||
| <DetailListTextValue | ||
| class="font-mono" |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Adds external payload count and size to workflow details page header
Screenshots (if applicable) 📸
with external payload(s)
without external payload(s) (unchanged)
Tooltip
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?