Open
Conversation
…3262) Create a reusable common-error component system for displaying operational guidance about workflow misconfigurations. Includes typed data for 35 known issues with severity levels, documentation links, and a /common-errors route.
Add automatic detection of 21 workflow configuration issues and display them as warnings in the workflow header. Detection covers timeout misconfigurations, retry policy issues, heartbeat settings, and more. Also fixes raw code references in error titles.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Alex-Tideman
changed the title
- Raise #31 threshold from 4000 to 10000 to match "significant additional events" - Add null guards to all getCommonErrorById calls via addError helper - Detect #3 (short timeout) from workflowRunTimeout on first event, not just execution timeout - Fix #10 false positives for empty retry policy objects - Handle protobuf nanos field in durationToSeconds for sub-second durations
Implement Tier 1 detections from existing data (#9, #11, #13, #15, #19, #23, #35) and Tier 2 detections from event history scanning (#8, #12, #26, #27, #28, #29, #30). Adds detectEventHistoryErrors with single-pass scanning and updates getApplicableCommonErrors to accept optional event history. All 35 error definitions now have active detection logic.
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| errorIds.add(23); | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ Type '(CommonError | undefined)[]' is not assignable to type 'CommonError[]'.
…flow-run-layout to svelte5
| if (hasLocalActivityMarker && hasWftFailure) { | ||
| errorIds.add(30); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ Type '(CommonError | undefined)[]' is not assignable to type 'CommonError[]'.
Update detectFirstEventErrors test calls to match updated function signature that removed the workflow parameter. Add missing routeForCommonErrors test case to route-for-base-path tests.
Switch from VerticalNav sidebar to TabButtons for severity filtering. Remove layout reset (@) since the page no longer needs a custom layout. Add WorkflowCommonErrors snippet to workflow run layout.
Rename $$Props to Props in alert.svelte for Svelte 5 convention. Update stories to use module script and ComponentProps for proper type inference with Storybook.
Alex-Tideman
changed the title
andrewzamojc
approved these changes
Apr 7, 2026
Contributor
andrewzamojc
left a comment
andrewzamojc
left a comment
There was a problem hiding this comment.
I tested locally by adding the snippet and starting a workflow that triggered some common errors. Looks good 👍
| $: (runId, clearWorkflowData()); | ||
| $effect(() => { | ||
| runId; | ||
| untrack(() => { |
Contributor
There was a problem hiding this comment.
i assume all this untrack is nessesary?
Collaborator
Author
There was a problem hiding this comment.
Yeah the way svelte5 works is it now tracks all the deps used in the function, not just the inputs. So this prevents overfetching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/common-errorsreference page with tab-based severity filteringFor this initial release, the Common Errors are not included by default to the Workflow Header. We will opt in to internally test first by including in the headerSnippet:
Test plan
To test common errors, you can include the above snippet and run workflows with any of the 35 scenarios such as a short workflowExecutionTimeout to view the error.