DT-3671 - standalone activity details redesign#3255
Draft
rossedfort wants to merge 9 commits intomainfrom
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| </div> | ||
| <DetailList aria-label="Retry Policy" rowCount={2}> | ||
| <DetailListColumn> | ||
| <DetailListLabel>Initial Interval</DetailListLabel> |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'number | undefined' is not assignable to parameter of type 'string | number'.
| <DetailListColumn> | ||
| <DetailListLabel>Initial Interval</DetailListLabel> | ||
| <DetailListTextValue text={fromSeconds(activity.initialInterval)} /> | ||
| <DetailListLabel>Maximum Interval</DetailListLabel> |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'number | undefined' is not assignable to parameter of type 'string | number'.
| {@const badgeType = failed ? 'danger' : 'default'} | ||
| {#if activity} | ||
| <div class="flex flex-col gap-4"> | ||
| <ActivityExecutionInputAndOutcome |
Contributor
There was a problem hiding this comment.
⚠️ '$activityExecution' is possibly 'undefined'.
| {#if activity} | ||
| <div class="flex flex-col gap-4"> | ||
| <ActivityExecutionInputAndOutcome | ||
| input={$activityExecution.input} |
Contributor
There was a problem hiding this comment.
⚠️ '$activityExecution' is possibly 'undefined'.
| <div class="flex flex-col gap-4"> | ||
| <ActivityExecutionInputAndOutcome | ||
| input={$activityExecution.input} | ||
| outcome={$activityExecution.outcome} |
Contributor
There was a problem hiding this comment.
⚠️ '$activityExecution' is possibly 'undefined'.
| this.backoffCoefficient = | ||
| activityExecution?.info?.retryPolicy.backoffCoefficient; | ||
| this.scheduleTime = activityExecution?.info?.scheduleTime; | ||
| this.currentInterval = formatSecondsAbbreviated( |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
| } | ||
|
|
||
| public intervalForAttempt(attempt: number): number { | ||
| return Math.min( |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
|
|
||
| public intervalForAttempt(attempt: number): number { | ||
| return Math.min( | ||
| this.initialInterval * Math.pow(this.backoffCoefficient, attempt - 1), |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| }), | ||
| ...(activityFormData.heartbeatTimeout && { | ||
| heartbeatTimeout: activityFormData.heartbeatTimeout, | ||
| }), |
Contributor
There was a problem hiding this comment.
⚠️ Type '{ backoffCoefficient?: number | undefined; maximumAttempts?: number | undefined; maximumInterval?: string | undefined; initialInterval?: string | undefined; }' is not assignable to type 'RetryPolicy'.
| }; | ||
|
|
||
| export const fromNumberToDuration = (duration: string): string => { | ||
| export const fromNumberToDuration = (duration: string | number): string => { |
Contributor
There was a problem hiding this comment.
⚠️ Type 'undefined' is not assignable to type 'string'.
Contributor
|
| public currentAttempt: number | undefined = $state(); | ||
| public scheduleTime: string | undefined = $state(); | ||
| public lastAttemptCompletedTime: string | undefined = $state(); | ||
| public nextAttemptScheduleTime: string | undefined = $state(); |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| public upcomingAttempts = $derived( | ||
| this.running | ||
| ? this.buildUpcomingAttempts( | ||
| this.activityExecution?.info?.lastAttemptCompleteTime, |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'number | undefined' is not assignable to parameter of type 'number'.
| : [], | ||
| ); | ||
|
|
||
| public attemptsRemaining = $derived( |
Contributor
There was a problem hiding this comment.
⚠️ Object is possibly 'undefined'.⚠️ Object is possibly 'undefined'.
|
|
||
| public secondsRemaining = $derived.by(() => { | ||
| if (this.maximumAttempts) { | ||
| let total = 0; |
Contributor
There was a problem hiding this comment.
⚠️ 'a' is possibly 'undefined'.⚠️ 'a' is possibly 'undefined'.
|
|
||
| const startToCloseTimeoutMillis = this.startToCloseTimeoutSeconds * 1000; | ||
|
|
||
| const endTime = new SvelteDate( |
Contributor
There was a problem hiding this comment.
⚠️ Object is possibly 'undefined'.
| activityExecution?.info?.lastAttemptCompleteTime; | ||
| this.nextAttemptScheduleTime = | ||
| activityExecution?.info?.nextAttemptScheduleTime; | ||
| this.closeTime = activityExecution?.info?.closeTime; |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| activityExecution?.info.scheduleToCloseTimeout; | ||
| this.startToCloseTimeout = activityExecution?.info?.startToCloseTimeout; | ||
| this.scheduleToStartTimeout = | ||
| activityExecution?.info?.scheduleToStartTimeout; |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| } | ||
|
|
||
| public intervalForAttempt(attempt: number): number { | ||
| return Math.min( |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'number | undefined' is not assignable to parameter of type 'number'.⚠️ Object is possibly 'undefined'.
|
|
||
| public intervalForAttempt(attempt: number): number { | ||
| return Math.min( | ||
| this.initialInterval * Math.pow(this.backoffCoefficient, attempt - 1), |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'number | undefined' is not assignable to parameter of type 'number'.
| expect(activity.running).toBe(true); | ||
| expect(activity.upcomingAttempts.length).toBe(51); // includes current attempt | ||
| expect(activity.secondsRemaining).toBe(5500); | ||
| expect(activity.nextRetrySecondsLeft).toBe('1m 40s'); |
Contributor
There was a problem hiding this comment.
⚠️ 'activity.deadlineTime' is possibly 'undefined'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Better UI for the standalone activity details page
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?